128578 - Need a way to SetTextZoom without reflowing content

Status: RESOLVED DUPLICATE of bug 108391

(Core Graveyard :: Embedding: APIs, enhancement)

Description

[Marco Pesenti Gritti]

It would be useful to implement features like per-site zoom saving.
In that case you want the zoom to be applied only on the next page load.

We are forced to use nsIDeviceContext to do that in galeon atm.

A possible way to fix this would be to extend the SetTextZoom api
(nsIMarkupDocumentViewer) with a PRBool reflow.

In DocumentViewer.cpp

NS_IMETHODIMP DocumentViewerImpl::SetTextZoom(float aTextZoom, PRBool reflow)
{
  if (mDeviceContext) {
    mDeviceContext->SetTextZoom(aTextZoom);
    if (reflow && mPresContext) {
      mPresContext->ClearStyleDataAndReflow();
    }
  }

  // now set the text zoom on all children of mContainer
  struct TextZoomInfo textZoomInfo = { aTextZoom };
  return CallChildren(SetChildTextZoom, &textZoomInfo);
}

Comment 1

[R.K.Aa.]

Resolving as duplicate of bug 108391, there are dups/comments there already and
the bug is assigned. Please add comments.

*** This bug has been marked as a duplicate of 108391 ***

Comment 2

[R.K.Aa.]

hmm reading this bug closer, it's not an exact dup - please reopen if i
misinterpreted this.

Comment 3

[Marco Pesenti Gritti]

It's not the same. I'm asking an api extension to be able to implement something
silimar to 108391 in an embedded application. I'm not asking to implement it in
mozilla-the-browser.

Comment 4

[Adam Lock]

I think this is a dupe. Bug 108391 hasn't even been implemented yet, so it seems
pointless to have two bugs open when the fix for bug 108391 should rightly
address this aspect also.

Subscribe to the other bug and ensure that the patch addresses your embedding
requirements. At a minimum I would like to see the per-site settings available
via prefs or some other mechanism.

*** This bug has been marked as a duplicate of 108391 ***