1285780 - Addon Debugger 48.0b6 problems

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P2)

Description

[bugzilla12345678]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140911151253

Steps to reproduce:

I am working on an addon with webextenstion. Currently I am debugging a function to store data. I updated Firefox, created new profile, and added my addon to debugger. Connected. The I click on Debugger tab. I click on button of my addon and select one item of list to see js file I am debugging. Then I add bookmark to the code which I intentionally added:

function saveOptions(e) {
  var test = document.getElementById("test").value;
}

there is a bug on the second line because there is not element with id test. I placed my bookmark on the second line. I opened a form where I change some data, listener is called to call saveOptions and code is break. Then I press F10 to then again and Debugger halts. OK, I have found a bug. But the problem I see here is that I need to close the Firefox now, correct the bug and then repeat every step. 


Actual results:

Bug 1)
When I close the debugger at the moment when it stepped out in the line with a bug, the main Firefox window does not respond do I need to force close from Task Manager in Windows (XP 32bit). So this is the reason why I need to close the main window instead Debugger. I miss buttons to cancel/abort debugging or restart the Debugger. So the only way I can continue is to restart the Firefox. This is depressing. For every single bug I need to do this. It often is undefined variable or even when I use document.getElementById for id which does not exist in document.

Bug 2) The Debugger does not reflect changes in script file - I reload the Addon but the tab Debuggger does not refresh the file which I am watching. This is also the reason why I need to restart Firefox. I am not able to repeat the debugging after restart of the addon because it will not jump to the bookmark. Notice, the html page redirected after I saved the form. I dont know if this could be the reason why Debugger does not jump to the saveOptions function onto the line with bookmark.


Expected results:

When I restart Addon, the Addon Debugger which is connected to addon should see the changes in file, should restart the debuging proccess. I should be able to repeat debugging and jump to the function where the bookmark is placed. I suggest adding a button to reset Debugger completely + refresh the script files. It would make the debugging more easy and faster.

Comment 1

[bugzilla12345678]

The Debugger freezez in such situation:

I have a popup. When I click on item in the popup I open new tab. When I close the tab, the Debugger is freezed and it is not possible to restart it or to interact with the Browser Tabs. So I need to restart it. This is highly irritating. Now I know I must not close the tab, but often I do instinctively so I must restart and repeat connection to the addon. This is damn work.

Comment 2

[bugzilla12345678]

If I am debugging in Addon Debugger and I step on certain line (F10), then if I close the Debugger window the browser is freezed and must be closed from Task Manager. It is impossible to restart Debugger. One must not close the Window but if I do by incident than it is complication.

Comment 3

[Eddy Bruel [:ejpbruel]]

I had some trouble parsing what the actual problem is you're running into. Is this a good summary of your problem?

If you close the add-on debugger while the debugger is still in the paused state, the main browser window becomes unresponsive.

Tentatively assigning P2 to this, assuming that the above summary is correct. If that's the case, that's a rather annoying problem, which should be easy to fix (we fixed a similar problem for service worker debugging a while ago).

Comment 4

[bugzilla12345678]

"If you close the add-on debugger while the debugger is still in the paused
state, the main browser window becomes unresponsive."

This is correct. Thank you.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Jason,
Do you think we should close it? Thanks

Comment 6

[Jason Laster [:jlast]]

CC Honza, would you be able to look into this?

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I did test both bugs mentioned in comment #0 with my test webextension and both works fine for me.

Bug 1) When I close the debugger at the moment when it stepped out in the line with a bug, the main Firefox window does not respond

Closing the debugger doesn't break the debugee window for me.

Bug 2) The Debugger does not reflect changes in script file

When changing the code and reloading the webextension (using Reload button in about:debugging page) the Debugger shows new source.

@bugzilla12345678: I am closing this report, but feel free to reopen if you see the issue again.

Thanks for the report!

Honza