1285817 - Change for .emailDisplayButton:focus from border to outline

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

When using TAB and the .emailDisplayButton in the message header is focused, the whole header grows because the focus border is added.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: outline.patch

Using the outline stops this jumping. Also the star shrinks on focus. Also changed it to outline.

Aside of this, what do you think about the orange appearance on hover? Shouldn't we use the blue button appearance?

Comment 2

[aleth [:aleth]]

For a quick review, could you add a screenshot please? I don't have a working build at the moment.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: addressFocusHover.png

Screenshot: on top the focused address and on bottom the hovered address.

Comment 4

[aleth [:aleth]]

Comment on attachment 8769491 [details] [diff] [review]
outline.patch

Review of attachment 8769491 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good to me, thanks.

But I agree the orange is a bit strange, it's certainly not native-looking.

Comment 5

[Richard Marti (:Paenglab)]

(In reply to aleth [:aleth] from comment #4)
> 
> But I agree the orange is a bit strange, it's certainly not native-looking.

I'll file a bug to investigate a better color.

Comment 6

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/f6adc8d3dd22