Closed Bug 1285817 Opened 4 years ago Closed 4 years ago

Change for .emailDisplayButton:focus from border to outline

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 50.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

When using TAB and the .emailDisplayButton in the message header is focused, the whole header grows because the focus border is added.
Attached patch outline.patchSplinter Review
Using the outline stops this jumping. Also the star shrinks on focus. Also changed it to outline.

Aside of this, what do you think about the orange appearance on hover? Shouldn't we use the blue button appearance?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8769491 - Flags: review?(aleth)
For a quick review, could you add a screenshot please? I don't have a working build at the moment.
Attached image addressFocusHover.png
Screenshot: on top the focused address and on bottom the hovered address.
Comment on attachment 8769491 [details] [diff] [review]
outline.patch

Review of attachment 8769491 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good to me, thanks.

But I agree the orange is a bit strange, it's certainly not native-looking.
Attachment #8769491 - Flags: review?(aleth) → review+
(In reply to aleth [:aleth] from comment #4)
> 
> But I agree the orange is a bit strange, it's certainly not native-looking.

I'll file a bug to investigate a better color.
https://hg.mozilla.org/comm-central/rev/f6adc8d3dd22
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 50.0
You need to log in before you can comment on or make changes to this bug.