1285831 - bluetoothd won't build with BOARD_BLUETOOTH_BDROID_USE_CAF_EXTENSIONS defined

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Bonstra]

bluetoothd will fail to build if BOARD_BLUETOOTH_BDROID_USE_CAF_EXTENSIONS is set to true in the BoardConfig.mk and building with a libhardware from CAF.
The problem comes from an unused parameter in the pin_request_cb() function, which causes the compiler to issue a warning and subsequently fail because of the -Werror option in the LOCAL_CFLAGS. That parameter "secure" is only present when Q_BLUETOOTH is defined, and Q_BLUETOOTH is defined only if BOARD_BLUETOOTH_BDROID_USE_CAF_EXTENSIONS is "true".

=== Compiler output ===
target thumb C: bluetoothd <= system/bluetoothd/src/bt-core-io.c
system/bluetoothd/src/bt-core-io.c: In function 'pin_request_cb':
system/bluetoothd/src/bt-core-io.c:529:38: error: unused parameter 'secure' [-Werror=unused-parameter]
cc1: all warnings being treated as errors
make: *** [out/target/product/zte_p821a10/obj/EXECUTABLES/bluetoothd_intermediates/bt-core-io.o] Error 1
===

Comment 1

[Bonstra]

Attachment: github pull request

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8769504 [details] [review]
github pull request

Thank you!

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/0a5aa7225129b792c19e91be88eac97a89c089b6