Closed Bug 1285891 Opened 4 years ago Closed 3 years ago

Update notification anchor icon for plugins

Categories

(Firefox :: General, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 50
Iteration:
50.4 - Aug 1
Tracking Status
firefox50 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

(Depends on 2 open bugs)

Details

(Whiteboard: [fxprivacy] )

Attachments

(1 file)

... to match the flat notification icon style. See http://people.mozilla.org/~bbell/control-center-icons/
Blocks: 1285893
Aislinn, I'd leave it up to you how we want to proceed here. I'd personally really like to switch the icon for consistency, but there are 3 different icon variations (http://searchfox.org/mozilla-central/source/browser/themes/shared/plugins) that we'd have to change.
Flags: needinfo?(agrigas)
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Flags: needinfo?(agrigas)
Priority: -- → P2
Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64606/diff/1-2/
Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64606/diff/2-3/
Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

https://reviewboard.mozilla.org/r/64606/#review61918

Thanks!
Attachment #8771459 - Flags: review?(paolo.mozmail) → review+
Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64606/diff/3-4/
https://hg.mozilla.org/integration/fx-team/rev/a5a2837e3fed3cfdf6be39fa756e3be7e1257190
Bug 1285891 - Update notification anchor icon for plugins to SVG. r=paolo
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/a5a2837e3fed
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Iteration: --- → 50.4 - Aug 1
Should there be seen any visual changes, now that we use svg?
Flags: needinfo?(jhofmann)
Yes, the plugin icons should look more "flat", like this http://people.mozilla.org/~bbell/control-center-icons/images/glyph-plugin-32.svg.

That's basically it. You could test if the red warning icon (now also flat) still correctly appears when using an outdated e.g. Flash plugin. :)
Flags: needinfo?(jhofmann)
(In reply to Johann Hofmann [:johannh] from comment #10)
> That's basically it. You could test if the red warning icon (now also flat)
> still correctly appears when using an outdated e.g. Flash plugin. :)
There is a problem here. IIRC, if a plugin is blocked and outdated/vulnerable, the red icon should persist after the plugin is unblocked. Now the red icons becomes gray after unblock.
Flags: needinfo?(jhofmann)
What I can reproduce is that after reloading the page the icon is now gray, in both Nightly and Stable. That's definitely confusing, but not a regression of this bug. If that's what you meant, feel free to create an issue for it :)
Flags: needinfo?(jhofmann)
You're right, it seems to be an old bug actually - bug 901451.
Depends on: 901451
Depends on: 1290912
We need a second state (without crossed out) for the red icon, when the plugin is unblocked - filed bug 1290912.

Verified fixed FX 50.0a1 (2016-08-01) Win 7, Ubuntu 14.04, OS X 10.9.5.
Status: RESOLVED → VERIFIED
Thanks, I agree, we'll triage it.
Depends on: 1301851
You need to log in before you can comment on or make changes to this bug.