1285891 - Update notification anchor icon for plugins

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Johann Hofmann [:johannh]]

... to match the flat notification icon style. See http://people.mozilla.org/~bbell/control-center-icons/

Comment 1

[Johann Hofmann [:johannh]]

Aislinn, I'd leave it up to you how we want to proceed here. I'd personally really like to switch the icon for consistency, but there are 3 different icon variations (http://searchfox.org/mozilla-central/source/browser/themes/shared/plugins) that we'd have to change.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review commit: https://reviewboard.mozilla.org/r/64606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64606/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64606/diff/1-2/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64606/diff/2-3/

Comment 5

[:Paolo Amadini]

Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

https://reviewboard.mozilla.org/r/64606/#review61918

Thanks!

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8771459 [details]
Bug 1285891 - Update notification anchor icon for plugins to SVG.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64606/diff/3-4/

Comment 7

[Johann Hofmann [:johannh]]

https://hg.mozilla.org/integration/fx-team/rev/a5a2837e3fed3cfdf6be39fa756e3be7e1257190
Bug 1285891 - Update notification anchor icon for plugins to SVG. r=paolo

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5a2837e3fed

Comment 9

[Paul Silaghi, QA [:pauly]]

Should there be seen any visual changes, now that we use svg?

Comment 10

[Johann Hofmann [:johannh]]

Yes, the plugin icons should look more "flat", like this http://people.mozilla.org/~bbell/control-center-icons/images/glyph-plugin-32.svg.

That's basically it. You could test if the red warning icon (now also flat) still correctly appears when using an outdated e.g. Flash plugin. :)

Comment 11

[Paul Silaghi, QA [:pauly]]

(In reply to Johann Hofmann [:johannh] from comment #10)
> That's basically it. You could test if the red warning icon (now also flat)
> still correctly appears when using an outdated e.g. Flash plugin. :)
There is a problem here. IIRC, if a plugin is blocked and outdated/vulnerable, the red icon should persist after the plugin is unblocked. Now the red icons becomes gray after unblock.

Comment 12

[Paul Silaghi, QA [:pauly]]

For testing: http://benjamin.smedbergs.us/tests/ctptests/#single-outdated

Comment 13

[Johann Hofmann [:johannh]]

What I can reproduce is that after reloading the page the icon is now gray, in both Nightly and Stable. That's definitely confusing, but not a regression of this bug. If that's what you meant, feel free to create an issue for it :)

Comment 14

[Paul Silaghi, QA [:pauly]]

You're right, it seems to be an old bug actually - bug 901451.

Comment 15

[Paul Silaghi, QA [:pauly]]

We need a second state (without crossed out) for the red icon, when the plugin is unblocked - filed bug 1290912.

Verified fixed FX 50.0a1 (2016-08-01) Win 7, Ubuntu 14.04, OS X 10.9.5.

Comment 16

[Johann Hofmann [:johannh]]

Thanks, I agree, we'll triage it.