test_ChildHistograms.js is failing locally on Linux

RESOLVED WORKSFORME

Status

()

P3
normal
RESOLVED WORKSFORME
2 years ago
2 years ago

People

(Reporter: Dexter, Unassigned)

Tracking

Trunk
All
Linux
Points:
---

Firefox Tracking Flags

(firefox50 affected)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8769636 [details]
failure_log.txt

The latest m-c [1] is making test_ChildHistograms.js [2] permanently fail locally on my system.

Apparently, TELEMETRY_TEST_* histograms are not being reported in content processes.

[1] - https://hg.mozilla.org/mozilla-central/rev/1bee8d2da23e
[2] - https://dxr.mozilla.org/mozilla-central/rev/23dc78b7b57e9f91798ea44c242a04e112c37db0/toolkit/components/telemetry/tests/unit/test_ChildHistograms.js
Priority: -- → P2
Whiteboard: [measurement:client]
(Reporter)

Updated

2 years ago
OS: All → Linux
(Reporter)

Comment 1

2 years ago
The problem itself is:

 0:03.51 TEST_STATUS: Thread-3 parent  PASS Child payload should have keyed histograms. - true == true
 0:03.51 TEST_STATUS: Thread-3 parent  FAIL Should have count test histogram. - false == true
    /home/dexter/mozilla-central/objdir-ff-debug/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_ChildHistograms.js:check_histogram_values:38
    /home/dexter/mozilla-central/objdir-ff-debug/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_ChildHistograms.js:null:96
    _run_next_test@/home/dexter/mozilla-central/testing/xpcshell/head.js:1564:9
    do_execute_soon/<.run@/home/dexter/mozilla-central/testing/xpcshell/head.js:712:9
    _do_main@/home/dexter/mozilla-central/testing/xpcshell/head.js:209:5
    _execute_test@/home/dexter/mozilla-central/testing/xpcshell/head.js:544:5
    @-e:1:1
 0:03.51 LOG: Thread-3 parent INFO exiting test
 0:03.51 LOG: Thread-3 parent ERROR Unexpected exception 2147500036
undefined

With 

0:03.63 LOG: Thread-3 child INFO "CONSOLE_MESSAGE: (info) 1468233062919	Toolkit.Telemetry	TRACE	TelemetrySession#content::getHistograms - Skipping test histogram: TELEMETRY_TEST_FLAG"
 0:03.64 PROCESS_OUTPUT: Thread-3 (pid:28060) 

A few lines below.

Comment 2

2 years ago
Which means this._testing is false. Bummer.

I happen to be rewriting the test for bug 1218576, so maybe this'll all shake out when that mass of patches is landable?
(Reporter)

Comment 3

2 years ago
(In reply to Chris H-C :chutten from comment #2)
> Which means this._testing is false. Bummer.
> 
> I happen to be rewriting the test for bug 1218576, so maybe this'll all
> shake out when that mass of patches is landable?

Sure!
(Reporter)

Updated

2 years ago
Depends on: 1218576
Priority: P2 → P3
(Reporter)

Comment 4

2 years ago
This is not happening any more.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Updated

2 years ago
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.