Closed Bug 1285926 Opened 4 years ago Closed 4 years ago

Add preference for enabling/disabling custom tabs support

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 50
Tracking Status
firefox51 --- verified

People

(Reporter: sebastian, Assigned: sebastian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Our custom tabs support is not ready to be enabled by default yet (Too much breakage with multiple browser windows). However we would like to use and test it in Nightly builds (See bug 1280148).

Let's add a visible preference to Nightly for custom tabs support (disabled by default).

* Interested developers and testers can enable the preference and use custom tabs.

* Side effect: We could think of letting such a preference ride the trains later (but enabled by default): Right now only developers of third-party using custom tabs are in control of the experience. Maybe some users want to explicitly open all URLs in their browser environment and not in a restricted custom tab.
Attachment #8769685 - Flags: review?(snorp) → review?(gkruglov)
Comment on attachment 8769685 [details]
Bug 1285926 - Add preference for enabling/disabling custom tabs support.

https://reviewboard.mozilla.org/r/63460/#review60872

Looks good.

Do you want to flip MOZ_ANDROID_CUSTOM_TABS as well? [0] Or is that flag set during nightly builds?

[0] https://dxr.mozilla.org/mozilla-central/source/mobile/android/moz.configure#42
Attachment #8769685 - Flags: review?(gkruglov) → review+
(In reply to :Grisha Kruglov from comment #2)
> Do you want to flip MOZ_ANDROID_CUSTOM_TABS as well? [0] Or is that flag set
> during nightly builds?

There's a patch for this in bug 1280148. :)
https://hg.mozilla.org/integration/fx-team/rev/98e51699f47e171256a8eb54605bed04a0be5e71
Bug 1285926 - Add preference for enabling/disabling custom tabs support. r=grisha
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/98e51699f47e
Add preference for enabling/disabling custom tabs support. r=grisha
https://hg.mozilla.org/mozilla-central/rev/98e51699f47e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
(In reply to Francesco Lodolo [:flod] from comment #7)
> I assume the traling space in the string is unneeded?
> https://hg.mozilla.org/mozilla-central/diff/98e51699f47e/mobile/android/base/
> locales/en-US/android_strings.dtd#l1.16

Argh. Yes.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Sebastian Kaspari (:sebastian) from comment #8)
> (In reply to Francesco Lodolo [:flod] from comment #7)
> > I assume the traling space in the string is unneeded?
> > https://hg.mozilla.org/mozilla-central/diff/98e51699f47e/mobile/android/base/
> > locales/en-US/android_strings.dtd#l1.16
> 
> Argh. Yes.

Feel free to change the string without a new ID.
https://hg.mozilla.org/mozilla-central/rev/3c9970f896eb
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
(In reply to Sebastian Kaspari (:sebastian) from comment #8)
> (In reply to Francesco Lodolo [:flod] from comment #7)
> > I assume the traling space in the string is unneeded?
> > https://hg.mozilla.org/mozilla-central/diff/98e51699f47e/mobile/android/base/
> > locales/en-US/android_strings.dtd#l1.16
> 
> Argh. Yes.

I’m afraid that also goes for trailing periods - feature description summaries like these (and pref_activity_stream_summary introduced by bug 1290012 to some extent) don’t require them; see similar instances. The 3 that do have them aren’t descriptions and therefore allowed.
Tested using:
Devices: Nexus 6 (Android 6.0), One A2001 (Android 5.1.1)
Build: Firefox for Android 51.0a1 (2016-08-10)
"Custom Tabs - Allow third-party apps to open URLs with a customized look and feel" is displayed in Advanced, under 'Experimental feature's and it's disabled by default.
You need to log in before you can comment on or make changes to this bug.