If two version of a WebExtensions with no id but the same name are loaded in about:debugging, it only appears once

NEW
Unassigned

Status

DevTools
about:debugging
P3
normal
2 years ago
a month ago

People

(Reporter: CosminB, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(firefox50 affected)

Details

(Whiteboard: triaged)

(Reporter)

Description

2 years ago
Steps to reproduce:

1.Load first version of a WebExtension in about:debugging
2.Load the second version for the WebExtension but from a different folder

Expected results:
The latest version is displayed correctly in about:addons

Actual results:
Both versions of the WebExtension are displayed in about:addons

Note/Issues:
Verified on FF50.0a1 (2016-07-10) (Win 7 64-bit).

Here is a video:http://screencast.com/t/ZVb7YLLdJhg
(Reporter)

Updated

2 years ago
Flags: needinfo?(lgreco)

Comment 1

2 years ago
Are these add-ons without an id in the manifest? If so this is expected behaviour, the id is calculated from the path so we have no way to detect if they are the same.
Flags: needinfo?(lgreco)

Updated

2 years ago
Flags: needinfo?(cosmin.badescu)

Comment 2

2 years ago
What's interesting is that there are two add-ons in about:addons, but only one add-on in about:debugging. Until you change the name of one of the add-ons so they don't collide. That seems like a slightly different bug and might be something to do with a name collision in about:debugging?

I don't think this is a huge issue though.
Component: WebExtensions → Developer Tools: about:debugging
Product: Toolkit → Firefox
Whiteboard: triaged

Updated

2 years ago
Priority: -- → P3
Summary: If two versions of a WebExtension are uploaded from different folders , both of them are displayed in about:addons → If two version of a WebExtensions with no id but the same name are loaded in about:debugging, it only appears once

Comment 3

2 years ago
The following seems to be the relevant line:

```
 render() {
   ...
   targets = targets.map(target => {
      let key = target.name || target.url || target.title;
      return targetClass({ client, key, target, debugDisabled });
    });
```

From https://dxr.mozilla.org/mozilla-central/source/devtools/client/aboutdebugging/components/target-list.js#27
(Reporter)

Comment 4

2 years ago
(In reply to Andy McKay [:andym] from comment #1)
> Are these add-ons without an id in the manifest? If so this is expected
> behaviour, the id is calculated from the path so we have no way to detect if
> they are the same.

Yes, the add-ons do not have an id in the manifest file.
Flags: needinfo?(cosmin.badescu)

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.