pulse_actions - Handle gracefully backfill requests for invalid job names

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: armenzg, Assigned: armenzg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

2 years ago
There's also a missing 'Sch' on the push.
Perhaps we don't handle exceptions nicely.

Jul 11 05:32:44 pulse-actions app/worker2.1: root	 INFO:	 #### New request ####. 
Jul 11 05:32:45 pulse-actions app/worker2.1: treeherder_job_action	 INFO:	 Backfill action requested by jmaher@mozilla.com for 'a924f21fbba63e31f663239d0a80489b051db1c5' 
Jul 11 05:32:45 pulse-actions app/worker2.1: treeherder_job_action	 INFO:	 Request for https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=0b4f2a4e42295c2ef0e293b18ca3cade2b6949b1&selectedJob=1253029 
Jul 11 05:32:46 pulse-actions app/worker2.1: mozci	 ERROR:	 Buildername a924f21fbba63e31f663239d0a80489b051db1c5 is *NOT* valid. 
Jul 11 05:32:46 pulse-actions app/worker2.1: mozci	 INFO:	 Check the file we just created builders.txt for a list of valid builders. 
Jul 11 05:32:46 pulse-actions app/worker2.1: treeherder_job_action	 INFO:	 Treeherder can send us invalid builder names. 
Jul 11 05:32:46 pulse-actions app/worker2.1: treeherder_job_action	 INFO:	 See https://bugzilla.mozilla.org/show_bug.cgi?id=1242038. 
Jul 11 05:32:46 pulse-actions app/worker2.1: root	 ERROR:	 'NoneType' object has no attribute '__getitem__' 
Jul 11 05:32:46 pulse-actions app/worker2.1: Traceback (most recent call last): 
Jul 11 05:32:46 pulse-actions app/worker2.1:   File "pulse_actions/worker.py", line 229, in message_handler 
Jul 11 05:32:46 pulse-actions app/worker2.1:     acknowledge=CONFIG['acknowledge']) 
Jul 11 05:32:46 pulse-actions app/worker2.1:   File "pulse_actions/worker.py", line 364, in route 
Jul 11 05:32:46 pulse-actions app/worker2.1:     revision=revision, **kwargs) 
Jul 11 05:32:46 pulse-actions app/worker2.1:   File "/app/pulse_actions/handlers/treeherder_job_action.py", line 136, in on_event 
Jul 11 05:32:46 pulse-actions app/worker2.1:     LOG.warning('Builder %s is invalid.' % buildername[0]) 
Jul 11 05:32:46 pulse-actions app/worker2.1: TypeError: 'NoneType' object has no attribute '__getitem__' 
Jul 11 06:28:57 pulse-actions app/worker2.1: root	 INFO:	 This log was produced by https://github.com/mozilla/pulse_actions in case you want to help us out! :D
(Assignee)

Comment 1

2 years ago
I was doing something silly by using a variable that had been set to None.

This is now fixed with:
https://github.com/mozilla/pulse_actions/commit/08ddfce80dbe10a1949fafb3dcb78c1a9173db26
Assignee: nobody → armenzg
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Summary: pulse_actions - Handle gracefully backfill requests from autophone → pulse_actions - Handle gracefully backfill requests for invalid job names
You need to log in before you can comment on or make changes to this bug.