If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Improve ForEachNode use in Resolve/DetachRefLayers.

RESOLVED FIXED in Firefox 50

Status

()

Core
Graphics: Layers
--
enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bobowen, Assigned: bobowen)

Tracking

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I noticed while working on bug 1252877, that ResolveRefLayers was using [1], when it might as well be using [2].

Also, DetachRefLayers would be better using ForEachNodePostOrder and there were checks being done that I think are only needed during Resolve.


[1] https://hg.mozilla.org/mozilla-central/file/214884d507ee/gfx/layers/TreeTraversal.h#l136
[2] https://hg.mozilla.org/mozilla-central/file/214884d507ee/gfx/layers/TreeTraversal.h#l146
(Assignee)

Comment 1

a year ago
Created attachment 8769744 [details] [diff] [review]
Improve ForEachNode use in Resolve/DetachRefLayers
Attachment #8769744 - Flags: review?(matt.woodrow)
(Assignee)

Comment 2

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=098e3c9d062cafe380c424b2b8271a13c7950958
Attachment #8769744 - Flags: review?(matt.woodrow) → review+

Comment 3

a year ago
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6044eec77a2c
Improve ForEachNode use in Resolve/DetachRefLayers. r=mattwoodrow

Comment 4

a year ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/940674ad1be3
Backed out changeset 6044eec77a2c for bustage on a CLOSED TREE
(Assignee)

Comment 5

a year ago
I'd only run static analysis on Linux, but on Mac and Android willResolvePlugins is no longer passed to a function, so now flagged as unused.

Here's a try push with a #if added for that, I also added the null check for aCompositor into that bool, because there is no point doing it every time in the loop:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3da3c7b712e

I think these changes are small enough to not need a re-review.

Comment 6

a year ago
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd659292794f
Improve ForEachNode use in Resolve/DetachRefLayers. r=mattwoodrow

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bd659292794f
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.