1286000 - Discarded child requests become orphaned

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: Extension, defect)

Description

[Steven MacLeod [:smacleod]]

When a series of review requests is closed->discarded, we remove the review identifier from the parent request so that it is possible to create a new series with the same user and bug number. This has the unintended side effect of making it so the child review requests are no longer able to find the parent review request.

This means when a user visits one of these discarded review requests a commit table will not be displayed. Even worse, if a new series has been created (a new parent with the same review id has been created) the child requests will believe it is their parent request. This will result in the old requests showing the commit table for the new series - very confusing.

Fixing this would be very easy if Bug 1246691 is fixed. Otherwise, we can probably store some new information about the parent child relationship in extra_data.

Comment 1

[Karl Tomlinson (:karlt)]

This makes bug 1234279 more problematic.

Comment 2

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.