1286001 - Device Modal Background Doesn't Stretch Properly

Status: RESOLVED INVALID

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Helen V. Holmes (:helenvholmes) (:✨)]

As jryans put it, we've struggled to find device-modal-background sizing nirvana. 

`It's not obvious what the right solution is, so I expect it will take a lot of experimentation.  (Maybe we should even write tests to check all the cases...?  It's really quite hard to test them all manually each time.)`

This bug depends on work done in bug 1266414 which currently hasn't landed yet.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

From duplicate bug 1300453:

Created attachment 8788016 [details]
Screenshot of issue

STR:
- Resize the viewport to a bigger size than the browser window
- Open device modal
- Scroll down RDM

AR:
- Overlay does not cover the whole screen

ER:
- Overlay should cover the whole screen

Additionally, the device modal should always be centered despite the RDM scroll position.

This can be easily be fixed by using position: fixed instead of absolute on appropriate elements.

Comment 3

[Martin Balfanz [:mbalfanz]]

With the latest redesign, the issues doesn't occur. Scrolling with the device modal open does not scroll the viewport "in the background" anymore. Closing the issue