1286018 - When selecting *nightly* jobs on Treeherder the job details pane always switches to the "Performance" tab

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Armen [:armenzg]]

We filed bug 1281601 in the past, however, I've noticed that this happens for nightly jobs.

I've verified that this does not happen for:
* test jobs
* build jobs

It happens for:
* talos jobs
* nightly jobs [1]

It seems that we track build times [2] for nightly builds and that is probably why we get the performance tab.

When I first poke wlach today about it was because I thought it was still happening for *any* job rather than just nightly jobs.

If that is the case, I'm happy to simply close as invalid. I still wanted to complete the whole feedback loop to keep paper trail of it.

Works for you?

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=214884d507ee369c1cf14edb26527c4f9a97bf48&filter-searchStr=nightly&group_state=expanded&selectedJob=4307590
[2] https://treeherder.mozilla.org/perf.html#/graphs?timerange=7776000&series=%5Bmozilla-central,d7e0d672f173e5386d39d54e050683e1ef6abedc,1,2%5D

Comment 1

[William Lachance (:wlach)]

I think we ought to only switch to the performance tab for genuine "performance" jobs i.e. not builds or unit tests. Not sure of the best way of doing this though (I guess we could add a new job type field to treeherder?)

Comment 2

[Ed Morley [:emorley]]

I believe that's what the intention of the current job type was?
ie: {build, unittest, performance, ...}

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Armen Zambrano - Back on March 27th [:armenzg] (EDT/UTC-4) from comment #0)
> I've verified that this does not happen for:
> * test jobs
> * build jobs

This does happen for build jobs now. For example, the "Bo" job here:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ae20c5a91d7b&filter-searchStr=asan%20Bo

Comment 4

[Daniel Holbert [:dholbert]]

Note that the TreeHerder "Job Details" pane is the only place (AFAIK) to get old ASAN builds for specific builds -- so it's kind of bad that this bug is causing those builds to be buried/hard-to-find.  Perhaps that impacts the priority of this bug?

(I can see this bug having been deprioritized when it was *only* about Nightly/Talos jobs and build jobs were unaffected. But perhaps we should circle back to this and fix it now?)

Comment 5

[Ed Morley [:emorley]]

(In reply to Daniel Holbert [:dholbert] from comment #4)
> Note that the TreeHerder "Job Details" pane is the only place (AFAIK) to get
> old ASAN builds for specific builds -- so it's kind of bad that this bug is
> causing those builds to be buried/hard-to-find.  Perhaps that impacts the
> priority of this bug?

If these are on Taskcluster, that sounds like a use-case that would be filled by the taskcluster artifacts API?

As for this bug, Will probably knows more than I.

Comment 6

[William Lachance (:wlach)]

I think this is a simple bug, I'll look into it tomorrow.

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Ed Morley [:emorley] from comment #5)
> If these [ASAN builds] are on Taskcluster, that sounds like a use-case that would be
> filled by the taskcluster artifacts API?

These are indeed on TaskCluster -- and I think I've used that the TaskCluster artifacts API's web page once before, but I don't recall where to find it (and I suspect most Gecko developers aren't going to be familiar with it).

So even if it's an alternate route to these builds, IMO we should keep the familiar TreeHerder route as frictionless as possible.

(In reply to William Lachance (:wlach) (use needinfo!) from comment #6)
> I think this is a simple bug, I'll look into it tomorrow.

Unless KWierso beats you to it? :D Looks like he just assigned himself.

Thanks for taking a look, everybody!

Comment 8

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:perftab > mozilla:master

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8844186 [details] [review]
[treeherder] KWierso:perftab > mozilla:master

This seems to work. 

startsWith() isn't supported in IE, but it is in Edge, so I think that's good enough?

Comment 10

[Ed Morley [:emorley]]

(In reply to Wes Kocher (:KWierso) from comment #9)
> startsWith() isn't supported in IE, but it is in Edge, so I think that's
> good enough?

We already use things broken in IE, so this is fine.

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7941cf7d26f9ac531f28e79e609b0e4b4018ed85
Bug 1286018 - Add a few other job_types that don't default to performance tab (#2228)

Comment 12

[William Lachance (:wlach)]

Comment on attachment 8844186 [details] [review]
[treeherder] KWierso:perftab > mozilla:master

LGTM. Thanks Wes!