Seccomp sandbox violation: sys_semctl called in content process of Firefox desktop

RESOLVED FIXED in Firefox 50

Status

()

Core
Security: Process Sandboxing
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: tedd, Assigned: tedd)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(crash signature)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
Crash reports show that sys_semctl is used in content process:

https://crash-stats.mozilla.com/search/?product=Firefox&reason=~SIGSYS&address=0x42&_sort=-date&_facets=cpu_arch&_facets=address&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports
(Assignee)

Comment 1

a year ago
Created attachment 8769844 [details] [diff] [review]
Add sys_semctl to seccomp whitelist and fix sys_semget. r=gcp

Try push for build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=088bf7a5e5f9

Also, I fixed the issue mentioned in Bug 1285525 Comment 11 with this patch.
Assignee: nobody → julian.r.hector
Attachment #8769844 - Flags: review?(gpascutto)
Underlying caller is ALSA, alsa_locked_pcm_open.
Attachment #8769844 - Flags: review?(gpascutto) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed
failed to apply:

patching file security/sandbox/linux/SandboxFilter.cpp
Hunk #2 FAILED at 635
1 out of 2 hunks FAILED -- saving rejects to file security/sandbox/linux/SandboxFilter.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh semctl.patch
Flags: needinfo?(julian.r.hector)
Keywords: checkin-needed
(Assignee)

Comment 4

a year ago
I will rebase the patch once the other patches landed that are currently on inbound.
Flags: needinfo?(julian.r.hector)
(Assignee)

Comment 5

a year ago
Created attachment 8770098 [details] [diff] [review]
Add sys_semctl to seccomp whitelist and fix sys_semget. r=gcp

Carry over r+

I rebased the patch against latest inbound, hopefully it will apply cleanly now.
Attachment #8769844 - Attachment is obsolete: true
Attachment #8770098 - Flags: review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfd94f28c573
Add sys_semctl to seccomp whitelist and fix sys_semget. r=gcp
Keywords: checkin-needed
(Assignee)

Updated

a year ago
Duplicate of this bug: 1286247

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dfd94f28c573
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Crash Signature: [@ libc-2.23.so@0xe8f4a ] [@ libc-2.23.so@0xe950a ] [@ libc-2.22.so@0xea6da ] [@ libc-2.19.so@0xfbdea ] [@ libc-2.23.so@0xe8b5a ] [@ libc-2.23.so@0x1083ea ] [@ libc-2.23.so@0xeb47a ]
You need to log in before you can comment on or make changes to this bug.