1286067 - second test case in test_fallback_cipher.js added for bug 1284840 is missing a parameter

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

https://hg.mozilla.org/mozilla-central/diff/e3dcf062007e/security/manager/ssl/tests/unit/test_fallback_cipher.js :

--- a/security/manager/ssl/tests/unit/test_fallback_cipher.js
+++ b/security/manager/ssl/tests/unit/test_fallback_cipher.js
@@ -219,21 +219,27 @@ add_task(function* () {
   // So we will see the crafted NS_ERROR_NET_RESET when we use
   // nsISocketTransport directly.
   yield startClient("server: fallback only, client: fallback enabled, public",
                     port, getXPCOMStatusFromNSS(SSL_ERROR_NO_CYPHER_OVERLAP),
                     {allowReset: true});
   // retry manually to simulate the HTTP layer
   yield startClient("server: fallback only, client: fallback enabled retry, public",
                     port, Cr.NS_OK);
+  // make sure that we remember the TLS intolerance
+  yield startClient("server: fallback only, client: second try after fallback success, public",
+                    port, Cr.NS_OK);
   yield startClient("server: fallback only, client: fallback enabled, private",
                     port, getXPCOMStatusFromNSS(SSL_ERROR_NO_CYPHER_OVERLAP),
                     {isPrivate: true, allowReset: true});
   yield startClient("server: fallback only, client: fallback enabled retry, private",
                     port, Cr.NS_OK, {isPrivate: true});
+  // make sure that we remember the TLS intolerance
+  yield startClient("server: fallback only, client: second try after fallback success, private",
+                    port, Cr.NS_OK);
 });
 
 do_register_cleanup(function() {
   do_print("reset modified prefs");
   for (let pref of fallback_cipher_prefs) {
     Services.prefs.clearUserPref(pref);
   }
 });

I think the second added test case is missing a {isPrivate: true} parameter at the end.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1286067 - add missing parameter for second test case added in bug 1284840

Review commit: https://reviewboard.mozilla.org/r/63566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63566/

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8769892 [details]
bug 1286067 - add missing parameter for second test case added in bug 1284840

https://reviewboard.mozilla.org/r/63566/#review60444

Oops.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

https://reviewboard.mozilla.org/r/63566/#review60444

No worries - thanks for the quick review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ec523b5fdd7
add missing parameter for second test case added in bug 1284840 r=emk

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ec523b5fdd7