Closed
Bug 1286080
Opened 8 years ago
Closed 8 years ago
tstclnt: incorrect error message for -H flag (requireDHNamedGroups)
Categories
(NSS :: Tools, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.28
People
(Reporter: bart.kosciarz, Assigned: catdesk)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
922 bytes,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36 Steps to reproduce: Look at the tstclient.c source code. More specifically: control-F of "if (requireDHNamedGroups)" in https://hg.mozilla.org/projects/nss/file/tip/cmd/tstclnt/tstclnt.c Actual results: An incorrect error message likely introduced in copy-pasting the error message format. Expected results: Error message should be something along the lines of: "error in requiring the use of fixed finite-field DH groups" rather than "error enabling extended master secret".
|
||
Updated•8 years ago
|
Keywords: good-first-bug
Attachment #8805762 -
Flags: review?(franziskuskiefer)
|
||
Updated•8 years ago
|
Assignee: nobody → catdesk
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8805762 [details] [diff] [review] 0001-Bug-1286080-tstclnt-incorrect-error-message-for-H-fl.patch Review of attachment 8805762 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this!
Attachment #8805762 -
Flags: review?(franziskuskiefer) → review+
|
|
||
Comment 4•8 years ago
|
||
landed as https://hg.mozilla.org/projects/nss/rev/b9bf1785300486add26bda75e36a6a115697ec23
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.28
You need to log in
before you can comment on or make changes to this bug.
Description
•