Closed
Bug 1286084
Opened 10 years ago
Closed 10 years ago
2,200 instances of "NS_ENSURE_TRUE(startupCache) failed" emitted from dom/xbl/nsXBLDocumentInfo.cpp during linux64 debug testing
Categories
(Core :: XBL, defect, P3)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
> 1076 WARNING: NS_ENSURE_TRUE(startupCache) failed: file dom/xbl/nsXBLDocumentInfo.cpp, line 265
This warning [1] shows up in the following test suites:
> 92 - [TC] Linux64 mochitest-2 2
> 55 - [TC] Linux64 mochitest-clipboard-e10s cl
> 49 - [TC] Linux64 mochitest-browser-chrome-e10s-4 bc4
> 42 - [TC] Linux64 mochitest-plain-e10s-3 3
> 41 - [TC] Linux64 mochitest-browser-chrome-e10s-7 bc7
> 41 - [TC] Linux64 mochitest-plain-e10s-9 9
> 35 - [TC] Linux64 mochitest-browser-chrome-e10s-6 bc6
> 33 - [TC] Linux64 mochitest-media-e10s mda
> 32 - [TC] Linux64 mochitest-plain-e10s-8 8
> 31 - [TC] Linux64 mochitest-plain-e10s-6 6
> 31 - [TC] Linux64 crashtest e10s C
> 30 - [TC] Linux64 mochitest-browser-chrome-e10s-3 bc3
> 29 - [TC] Linux64 mochitest-browser-chrome-e10s-5 bc5
> 28 - [TC] Linux64 mochitest-browser-chrome-e10s-1 bc1
> 28 - [TC] Linux64 mochitest-plain-e10s-10 10
> 26 - [TC] Linux64 mochitest-plain-e10s-2 2
> 26 - [TC] Linux64 firefox-ui-tests functional remote e10s en-US
> 26 - [TC] Linux64 firefox-ui-tests functional local e10s en-US
> 24 - [TC] Linux64 mochitest-browser-chrome-e10s-2 bc2
> 23 - [TC] Linux64 mochitest-plain-e10s-5 5
> 21 - [TC] Linux64 reftest-e10s-3 R-e10s3
> 21 - [TC] Linux64 reftest-noaccel-e10s-3 Ru3
> 18 - [TC] Linux64 reftest-e10s-8 R-e10s8
> 18 - [TC] Linux64 reftest-noaccel-e10s-8 Ru8
> 16 - [TC] Linux64 web-platform-tests-reftests-e10s Wr-e10s
> 16 - [TC] Linux64 mochitest-plain-e10s-4 4
> 16 - [TC] Linux64 web-platform-tests-e10s-5 5
> 15 - [TC] Linux64 mochitest-plain-e10s-7 7
> 15 - [TC] Linux64 mochitest-plain-e10s-1 1
> 12 - [TC] Linux64 web-platform-tests-e10s-3 3
> 11 - [TC] Linux64 reftest-e10s-2 R-e10s2
> 11 - [TC] Linux64 mochitest-gl-e10s gl
> 11 - [TC] Linux64 reftest-noaccel-e10s-2 Ru2
> 10 - [TC] Linux64 web-platform-tests-e10s-4 4
> 10 - [TC] Linux64 reftest-e10s-6 R-e10s6
> 10 - [TC] Linux64 mochitest-4 4
> 10 - [TC] Linux64 reftest-noaccel-e10s-6 Ru6
> 9 - [TC] Linux64 web-platform-tests-e10s-7 7
> 8 - [TC] Linux64 mochitest-chrome-3 c3
> 7 - [TC] Linux64 reftest-noaccel-e10s-5 Ru5
> 7 - [TC] Linux64 reftest-e10s-5 R-e10s5
> 7 - [TC] Linux64 mochitest-chrome-1 c1
> 6 - [TC] Linux64 reftest-noaccel-e10s-4 Ru4
> 6 - [TC] Linux64 mochitest-gpu-e10s gpu
> 6 - [TC] Linux64 reftest-e10s-4 R-e10s4
> 5 - [TC] Linux64 mochitest-clipboard cl
> 5 - [TC] Linux64 reftest-e10s-1 R-e10s1
> 5 - [TC] Linux64 mochitest-5 5
> 5 - [TC] Linux64 reftest-noaccel-e10s-1 Ru1
> 4 - [TC] Linux64 web-platform-tests-e10s-9 9
> 4 - [TC] Linux64 mochitest-3 3
> 4 - [TC] Linux64 mochitest-browser-chrome-6 bc6
> 3 - [TC] Linux64 web-platform-tests-e10s-1 1
> 3 - [TC] Linux64 mochitest-10 10
> 2 - [TC] Linux64 mochitest-browser-chrome-4 bc4
> 2 - [TC] Linux64 web-platform-tests-e10s-2 2
> 2 - [TC] Linux64 web-platform-tests-e10s-12 12
> 2 - [TC] Linux64 jsreftest e10s J
> 1 - [TC] Linux64 web-platform-tests-e10s-8 8
> 1 - [TC] Linux64 mochitest-a11y a11y
> 1 - [TC] Linux64 web-platform-tests-e10s-6 6
> 1 - [TC] Linux64 mochitest-browser-chrome-3 bc3
> 1 - [TC] Linux64 mochitest-browser-chrome-2 bc2
> 1 - [TC] Linux64 mochitest-1 1
> 1 - [TC] Linux64 web-platform-tests-e10s-11 11
> 1 - [TC] Linux64 mochitest-9 9
> 1 - [TC] Linux64 web-platform-tests-e10s-10 10
> 1 - [TC] Linux64 reftest-e10s-7 R-e10s7
> 1 - [TC] Linux64 mochitest-chrome-2 c2
It shows up in 558 tests. A few of the most prevalent:
> 149 - [e10s] Shutdown
> 12 - [e10s] browser/components/sessionstore/test/browser_crashedTabs.js
> 10 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/869833-1.xul == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/869833-1-ref.xul
> 10 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/331809-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/331809-1-ref.html
> 7 - [e10s] /webvtt/rendering/cues-with-video/processing-model/audio_has_no_subtitles.html
> 7 - [e10s] devtools/client/inspector/markup/test/browser_markup_links_04.js
> 6 - [e10s] dom/canvas/test/webgl-conf/generated/test_conformance__extensions__oes-texture-float-with-video.html
> 6 - [e10s] toolkit/content/tests/widgets/test_audiocontrols_dimensions.html
> 6 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/native-theme/470711-1.xul == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/native-theme/470711-1-ref.xul
> 6 - [e10s] browser/base/content/test/general/browser_bug719271.js
[1] https://hg.mozilla.org/mozilla-central/annotate/214884d507ee/dom/xbl/nsXBLDocumentInfo.cpp#l265
| Assignee | ||
Comment 1•10 years ago
|
||
There's another warning almost always in tandem, roughly doubling the amount of warnings:
> 1077 WARNING: NS_ENSURE_TRUE(startupCache) failed: file dom/xbl/nsXBLDocumentInfo.cpp, line 198
This warning [1] shows up in the following test suites:
> 92 - [TC] Linux64 mochitest-2 2
> 55 - [TC] Linux64 mochitest-clipboard-e10s cl
> 49 - [TC] Linux64 mochitest-browser-chrome-e10s-4 bc4
> 42 - [TC] Linux64 mochitest-plain-e10s-3 3
> 41 - [TC] Linux64 mochitest-browser-chrome-e10s-7 bc7
> 41 - [TC] Linux64 mochitest-plain-e10s-9 9
> 35 - [TC] Linux64 mochitest-browser-chrome-e10s-6 bc6
> 33 - [TC] Linux64 mochitest-media-e10s mda
> 32 - [TC] Linux64 mochitest-plain-e10s-8 8
> 31 - [TC] Linux64 mochitest-plain-e10s-6 6
> 31 - [TC] Linux64 crashtest e10s C
> 30 - [TC] Linux64 mochitest-browser-chrome-e10s-3 bc3
> 29 - [TC] Linux64 mochitest-browser-chrome-e10s-5 bc5
> 28 - [TC] Linux64 mochitest-browser-chrome-e10s-1 bc1
> 28 - [TC] Linux64 mochitest-plain-e10s-10 10
> 26 - [TC] Linux64 mochitest-plain-e10s-2 2
> 26 - [TC] Linux64 firefox-ui-tests functional remote e10s en-US
> 26 - [TC] Linux64 firefox-ui-tests functional local e10s en-US
> 24 - [TC] Linux64 mochitest-browser-chrome-e10s-2 bc2
> 23 - [TC] Linux64 mochitest-plain-e10s-5 5
> 21 - [TC] Linux64 reftest-e10s-3 R-e10s3
> 21 - [TC] Linux64 reftest-noaccel-e10s-3 Ru3
> 18 - [TC] Linux64 reftest-e10s-8 R-e10s8
> 18 - [TC] Linux64 reftest-noaccel-e10s-8 Ru8
> 16 - [TC] Linux64 web-platform-tests-reftests-e10s Wr-e10s
> 16 - [TC] Linux64 mochitest-plain-e10s-4 4
> 16 - [TC] Linux64 web-platform-tests-e10s-5 5
> 15 - [TC] Linux64 mochitest-plain-e10s-7 7
> 15 - [TC] Linux64 mochitest-plain-e10s-1 1
> 12 - [TC] Linux64 web-platform-tests-e10s-3 3
> 11 - [TC] Linux64 reftest-noaccel-e10s-2 Ru2
> 11 - [TC] Linux64 reftest-e10s-2 R-e10s2
> 11 - [TC] Linux64 mochitest-gl-e10s gl
> 10 - [TC] Linux64 web-platform-tests-e10s-4 4
> 10 - [TC] Linux64 reftest-e10s-6 R-e10s6
> 10 - [TC] Linux64 mochitest-4 4
> 10 - [TC] Linux64 reftest-noaccel-e10s-6 Ru6
> 9 - [TC] Linux64 web-platform-tests-e10s-7 7
> 8 - [TC] Linux64 mochitest-chrome-3 c3
> 7 - [TC] Linux64 reftest-noaccel-e10s-5 Ru5
> 7 - [TC] Linux64 reftest-e10s-5 R-e10s5
> 7 - [TC] Linux64 mochitest-chrome-1 c1
> 6 - [TC] Linux64 reftest-noaccel-e10s-4 Ru4
> 6 - [TC] Linux64 mochitest-gpu-e10s gpu
> 6 - [TC] Linux64 reftest-e10s-4 R-e10s4
> 5 - [TC] Linux64 mochitest-clipboard cl
> 5 - [TC] Linux64 reftest-e10s-1 R-e10s1
> 5 - [TC] Linux64 mochitest-5 5
> 5 - [TC] Linux64 reftest-noaccel-e10s-1 Ru1
> 4 - [TC] Linux64 web-platform-tests-e10s-9 9
> 4 - [TC] Linux64 mochitest-3 3
> 4 - [TC] Linux64 mochitest-browser-chrome-6 bc6
> 3 - [TC] Linux64 web-platform-tests-e10s-1 1
> 3 - [TC] Linux64 mochitest-10 10
> 2 - [TC] Linux64 mochitest-browser-chrome-4 bc4
> 2 - [TC] Linux64 web-platform-tests-e10s-2 2
> 2 - [TC] Linux64 web-platform-tests-e10s-12 12
> 2 - [TC] Linux64 jsreftest e10s J
> 1 - [TC] Linux64 web-platform-tests-e10s-8 8
> 1 - [TC] Linux64 mochitest-a11y a11y
> 1 - [TC] Linux64 web-platform-tests-e10s-6 6
> 1 - [TC] Linux64 mochitest-browser-chrome-3 bc3
> 1 - [TC] Linux64 mochitest-browser-chrome-2 bc2
> 1 - [TC] Linux64 mochitest-1 1
> 1 - [TC] Linux64 web-platform-tests-e10s-11 11
> 1 - [TC] Linux64 mochitest-9 9
> 1 - [TC] Linux64 web-platform-tests-e10s-10 10
> 1 - [TC] Linux64 reftest-e10s-7 R-e10s7
> 1 - [TC] Linux64 mochitest-chrome-2 c2
> 1 - [TC] Linux64 reftest-noaccel-e10s-7 Ru7
It shows up in 558 tests. A few of the most prevalent:
> 149 - [e10s] Shutdown
> 12 - [e10s] browser/components/sessionstore/test/browser_crashedTabs.js
> 10 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/869833-1.xul == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bidi/869833-1-ref.xul
> 10 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/331809-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/331809-1-ref.html
> 7 - [e10s] /webvtt/rendering/cues-with-video/processing-model/audio_has_no_subtitles.html
> 7 - [e10s] devtools/client/inspector/markup/test/browser_markup_links_04.js
> 6 - [e10s] dom/canvas/test/webgl-conf/generated/test_conformance__extensions__oes-texture-float-with-video.html
> 6 - [e10s] toolkit/content/tests/widgets/test_audiocontrols_dimensions.html
> 6 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/native-theme/470711-1.xul == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/native-theme/470711-1-ref.xul
> 6 - [e10s] browser/base/content/test/general/browser_bug719271.js
[1] https://hg.mozilla.org/mozilla-central/annotate/214884d507ee/dom/xbl/nsXBLDocumentInfo.cpp#l198
Summary: 1,100 instances of "NS_ENSURE_TRUE(startupCache) failed" emitted from dom/xbl/nsXBLDocumentInfo.cpp during linux64 debug testing → 2,200 instances of "NS_ENSURE_TRUE(startupCache) failed" emitted from dom/xbl/nsXBLDocumentInfo.cpp during linux64 debug testing
Comment 2•10 years ago
|
||
Neil, is there something you think we can do here?
Flags: needinfo?(enndeakin)
Priority: -- → P3
Comment 3•10 years ago
|
||
It looks like the startup cache is disabled in content processes. The warning should just be removed.
We might also look at what it would take to enable it, but that I don't know much about.
Flags: needinfo?(enndeakin)
Comment 4•10 years ago
|
||
Thanks, Neil. Looks like supporting the startup cache in content processes is bug 626814.
| Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8774840 -
Flags: review?(enndeakin)
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8774840 -
Flags: review?(enndeakin) → review+
| Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/84237932bc5a203f67024cd1bb37cfe335219e1c
Bug 1286084 - Remove warning that startup cache is null. r=enn
Comment 7•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•