Closed
Bug 1286108
Opened 8 years ago
Closed 8 years ago
Do not provide construction methods for JS::ubi::TracerConcrete[WithCompartment]
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
|
1.72 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
These are supposed to be helper base classes that should not be instantiated directly, so we shouldn't let it be possible to Concrete<T>::construct() them.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8769937 -
Flags: review?(jimb)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8769937 [details] [diff] [review] Do not provide construction methods for JS::ubi::TracerConcrete[WithCompartment] Review of attachment 8769937 [details] [diff] [review]: ----------------------------------------------------------------- If it compiles everywhere, this is totally cool with me.
Attachment #8769937 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efc9181a7268
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8769937 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/650c05d61a63 Do not provide construction methods for JS::ubi::TracerConcrete[WithCompartment]; r=jimb
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/650c05d61a63
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•