1286169 - Log addon name and version when logging info about reconciling addons.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

When diagnosing addon sync issues, it can be difficult to determine what addon is referenced in logs as GUIDs are typically the only thing logged (and often the only thing we have.

However, most logs start with, eg:

> Sync.AddonsReconciler	DEBUG	Rectifying state for addon d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d

But that this point we *do* have more info - with the following patch this log entry becomes:

> Sync.AddonsReconciler	DEBUG	Rectifying state for addon Adblock Plus (version=2.7.3, id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d})

Which makes it much easier to reconcile future log entries that just have the GUID with the specific addon being references.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1286169 - include addon names and versions in some Sync logs.

Review commit: https://reviewboard.mozilla.org/r/63642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63642/

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8770029 [details]
Bug 1286169 - include addon names and versions in some Sync logs.

https://reviewboard.mozilla.org/r/63642/#review60634

Looks good to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f230c122faa
include addon names and versions in some Sync logs. r=tcsc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f230c122faa