Closed
Bug 1286170
Opened 8 years ago
Closed 8 years ago
Fix SourceBufferIterator's move-assignment operator
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file)
1.84 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
I noticed while working on bug 1286161 that SourceBufferIterator's move-assignment operator is implemented wrong. It needs to let the previous owning SourceBuffer know that it's going away before it takes possession of the owner reference of the SourceBufferIterator that's being moved from. Otherwise the owning SourceBuffer never realizes that a reference to it has been dropped.
Assignee | ||
Comment 1•8 years ago
|
||
Here's the patch. We just do the same thing we do in the destructor.
Attachment #8770034 -
Flags: review?(edwin)
Attachment #8770034 -
Flags: review?(edwin) → review+
Pushed by mfowler@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8033580f6a1d Handle move-assignment of SourceBufferIterators correctly. r=edwin
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8033580f6a1d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•