Closed Bug 1286170 Opened 4 years ago Closed 4 years ago
Buffer Iterator's move-assignment operator
I noticed while working on bug 1286161 that SourceBufferIterator's move-assignment operator is implemented wrong. It needs to let the previous owning SourceBuffer know that it's going away before it takes possession of the owner reference of the SourceBufferIterator that's being moved from. Otherwise the owning SourceBuffer never realizes that a reference to it has been dropped.
Here's the patch. We just do the same thing we do in the destructor.
Attachment #8770034 - Flags: review?(edwin)
Attachment #8770034 - Flags: review?(edwin) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8033580f6a1d Handle move-assignment of SourceBufferIterators correctly. r=edwin
You need to log in before you can comment on or make changes to this bug.