Closed Bug 1286197 Opened 7 years ago Closed 7 years ago

../../../../../frameworks/native/include/gui/IConsumerListener.h:54:18: error: 'virtual void android::ConsumerListener::onFrameAvailable(const android::BufferItem&)' was hidden [-Werror=overloaded-virtual]

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1280600

People

(Reporter: gerard-majax, Unassigned)

References

Details

In file included from ../../../../config/system_wrappers/gui/IConsumerListener.h:3:0,
                 from ../../../../../frameworks/native/include/gui/BufferQueue.h:23,
                 from ../../../../config/system_wrappers/gui/BufferQueue.h:3,
                 from ../../../../../frameworks/native/include/gui/Surface.h:21,
                 from ../../../../config/system_wrappers/gui/Surface.h:3,
                 from /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/platforms/gonk/GonkAudioDecoderManager.cpp:8,
                 from Unified_cpp_platforms_gonk0.cpp:2:
../../../../../frameworks/native/include/gui/IConsumerListener.h:54:18: error: 'virtual void android::ConsumerListener::onFrameAvailable(const android::BufferItem&)' was hidden [-Werror=overloaded-virtual]
     virtual void onFrameAvailable(const BufferItem& item) = 0; /* Asynchronous */
                  ^
In file included from ../../../../dist/include/GonkConsumerBaseLL.h:28:0,
                 from ../../../../dist/include/GonkNativeWindowLL.h:27,
                 from ../../../../dist/include/GonkNativeWindow.h:17,
                 from /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/platforms/gonk/GonkVideoDecoderManager.h:15,
                 from /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/platforms/gonk/GonkDecoderModule.cpp:7,
                 from Unified_cpp_platforms_gonk0.cpp:11:
../../../../dist/include/GonkBufferQueueLL.h:67:22: error:   by 'virtual void android::GonkBufferQueue::ProxyConsumerListener::onFrameAvailable()' [-Werror=overloaded-virtual]
         virtual void onFrameAvailable();
                      ^
In file included from ../../../../config/system_wrappers/gui/IConsumerListener.h:3:0,
                 from ../../../../../frameworks/native/include/gui/BufferQueue.h:23,
                 from ../../../../config/system_wrappers/gui/BufferQueue.h:3,
                 from ../../../../../frameworks/native/include/gui/Surface.h:21,
                 from ../../../../config/system_wrappers/gui/Surface.h:3,
                 from /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/platforms/gonk/GonkAudioDecoderManager.cpp:8,
                 from Unified_cpp_platforms_gonk0.cpp:2:
../../../../../frameworks/native/include/gui/IConsumerListener.h:54:18: error: 'virtual void android::ConsumerListener::onFrameAvailable(const android::BufferItem&)' was hidden [-Werror=overloaded-virtual]
     virtual void onFrameAvailable(const BufferItem& item) = 0; /* Asynchronous */
                  ^
In file included from ../../../../dist/include/GonkNativeWindowLL.h:27:0,
                 from ../../../../dist/include/GonkNativeWindow.h:17,
                 from /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/platforms/gonk/GonkVideoDecoderManager.h:15,
                 from /home/alex/codaz/Mozilla/gecko-cinnabar/dom/media/platforms/gonk/GonkDecoderModule.cpp:7,
                 from Unified_cpp_platforms_gonk0.cpp:11:
../../../../dist/include/GonkConsumerBaseLL.h:111:18: error:   by 'virtual void android::GonkConsumerBase::onFrameAvailable()' [-Werror=overloaded-virtual]
     virtual void onFrameAvailable();
                  ^
This might affect only L devices.
Ok, so it looks like we are hitting an edge case where ANDROID_VERSION 21 methods differs from version 22. Now, before bug 1280600, a L 5.1.1 device build would be using ANDROID_VERSION == 21 ; while it is in fact 22. This could explain collision of methods.
Likely fixed by the landing of bug 1280600
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.