Closed Bug 1286232 Opened 4 years ago Closed 4 years ago

Add a scripted way of generating values in css-properties-db.js

Categories

(DevTools :: Framework, enhancement, P1)

49 Branch
enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.4 - Aug 1
Tracking Status
firefox50 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 1 obsolete file)

In the work to separate the client and server in devtools, we are creating a static list of CSS properties on the client. The list has been hand-generated every time. At this time we need a script to re-generate all of the values, and instructions on how to update the file. At this time this does not need to be included in the build system as that would be a lot of additional complexity. The script should be able to simply run from the Browser Console.

This bug came out of discussions from Bug 1265785.
Whiteboard: [devtools-html]
Blocks: 1275939
Whiteboard: [devtools-html] → [devtools-html] [triage]
Severity: normal → enhancement
Assignee: nobody → gtatum
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Flags: qe-verify? → qe-verify-
I ended up combining this bug and Bug 1286238 as the testing bug was already failing due to the fact that the CSS properties database has already changed! I'd have to land the scripting bug, then land the testing patch. In the interest of time they are combined here. I'm keeping this pretty manual, but I'm trying to be as explicit as I can in how to update the database so that anyone can come in and update it.
Attachment #8771054 - Flags: review?(pbrosset)
Comment on attachment 8771054 [details] [diff] [review]
Add scripts and tests to automate the css-properties-db.

Review of attachment 8771054 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great! Thanks a lot. Feels like we are in a much better position now to prevent future de-sync with platform and it'll be really easy to re-generate the lists.
Attachment #8771054 - Flags: review?(pbrosset) → review+
Duplicate of this bug: 1286238
Iteration: 50.3 - Jul 18 → 50.4 - Aug 1
This patch removes OS-specific tags, and makes the failing test more verbose
and specific to what failed.
Attachment #8771054 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/7e5277f1cf65
Add scripts and tests to automate the css-properties-db. r=pbro
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7e5277f1cf65
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Depends on: 1290971
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.