1286321 - script element: language attribute overrides type attribute when type is empty string

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Decky Coss (:deckycoss)]

according to the HTML standard, when a script element contains both a type attribute and a language attribute, the latter must be ignored, even if the value of the former is the empty string. (see step 6: https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script)

however, this test shows that the language attribute is used when the type is set to the empty string: http://w3c-test.org/html/semantics/scripting-1/the-script-element/script-language-type.html

Comment 1

[Decky Coss (:deckycoss)]

Attachment: Bug 1286321: always ignore language attribute when processing script element if type attribute is defined;

Review commit: https://reviewboard.mozilla.org/r/64280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64280/

Comment 2

[Decky Coss (:deckycoss)]

Comment on attachment 8771021 [details]
Bug 1286321: always ignore language attribute when processing script element if type attribute is defined;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64280/diff/1-2/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Would it make sense to just have GetScriptType return a boolean indicating whether there is an actual type?  That way you don't have to walk the attributes twice...

Comment 4

[Decky Coss (:deckycoss)]

(In reply to Boris Zbarsky [:bz] from comment #3)
> Would it make sense to just have GetScriptType return a boolean indicating
> whether there is an actual type?  That way you don't have to walk the
> attributes twice...

i wondered about that too. maybe GetScriptType can call GetAttr directly instead of calling GetType?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Indeed.  And then GetType() can call GetScriptType if we want to avoid the code duplication.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8771021 [details]
Bug 1286321: always ignore language attribute when processing script element if type attribute is defined;

Redirecting to Boris since he has opinions here.

Comment 7

[Decky Coss (:deckycoss)]

Comment on attachment 8771021 [details]
Bug 1286321: always ignore language attribute when processing script element if type attribute is defined;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64280/diff/2-3/

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8771021 [details]
Bug 1286321: always ignore language attribute when processing script element if type attribute is defined;

https://reviewboard.mozilla.org/r/64280/#review61360

::: dom/base/nsIScriptElement.h:55
(Diff revision 3)
>  
>    /**
>     * Content type identifying the scripting language. Can be empty, in
>     * which case javascript will be assumed.
>     */
> -  virtual void GetScriptType(nsAString& type) = 0;
> +  virtual bool GetScriptType(nsAString& type) = 0;

Please document what the return value means.

r=me

Comment 9

[Decky Coss (:deckycoss)]

Comment on attachment 8771021 [details]
Bug 1286321: always ignore language attribute when processing script element if type attribute is defined;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64280/diff/3-4/

Comment 10

[Decky Coss (:deckycoss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfb014a0f49f&selectedJob=24061277

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/264ffcf6eb58
always ignore language attribute when processing script element if type attribute is defined. r=bz

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/264ffcf6eb58