Closed Bug 1286325 Opened 4 years ago Closed 4 years ago

re-enable all geolocation tests

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(2 files, 1 obsolete file)

Lets investigate and try to re-enable the tests that were disabled on Android.  Much has changed in our testing since we disabled them.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=47c43ed07b17&selectedJob=23693150
did a little digging. Most of the android skip-ifs were added in bug 970925, but really they were format conversions from the old json skip format. So all of them are more than 30 months old. Most have the comment that they timed out, so getting a bunch of retriggers should be sufficient to be confident that they are no longer timing out.

[test_manyCurrentConcurrent.html] has the comment to not run modal tests on android, let's make sure what ever that is doing is kosher now.

[test_mozsettingsWatch.html] and [test_optional_api_params.html] say that they threw because mozSettings is undefined. One run should be sufficient to show that those tests are fine now.
Test suite M(16) contains the geolocation tests.
Attached patch geo_enable_all_tests (obsolete) — Splinter Review
Attachment #8770253 - Flags: review?(blassey.bugs)
Comment on attachment 8770253 [details] [diff] [review]
geo_enable_all_tests

Review of attachment 8770253 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming a green try run with multiple retriggers
Attachment #8770253 - Flags: review?(blassey.bugs) → review+
Carrying forward r+.  Patch now has the correct commit message.
Attachment #8770253 - Attachment is obsolete: true
Attachment #8770332 - Flags: review+
Keywords: checkin-needed
seems this does not apply cleanly to mozilla-inbound, dougt would it possible to rebase that patch ? Thanks!
Flags: needinfo?(dougt)
Keywords: checkin-needed
Attached patch inbound patchSplinter Review
Flags: needinfo?(dougt) → needinfo?(cbook)
thanks sir :) doing the checkin now!
Flags: needinfo?(cbook)
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39cac65eb07c
re-enable all geolocation tests. r=blassey
had to back this out because this caused merge conflicts with mozilla-central/autoland in
warning: conflicts while merging dom/tests/mochitest/geolocation/mochitest.ini! 

due to the changes in Bug 1286530
Flags: needinfo?(dougt)
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd1d2c40a07b
Backed out changeset 39cac65eb07c for causing merge conflicts with mozilla-central
please land attachment 8770332 [details] [diff] [review]
Flags: needinfo?(doug.turner)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ac4fc98ed0c
Re-enable all geolocation tests. r=blassey
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0ac4fc98ed0c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.