Closed Bug 1286331 Opened 7 years ago Closed 4 years ago

Create an automated way to upload OS X SDKs to tooltool

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: selenamarie, Assigned: ted)

Details

Attachments

(1 file)

bug 1286331 - document how to generate an SDK tarball. (DONTBUILD)
58 bytes, text/x-review-board-request
dustin
: review+
Details 
This is a bit tricky, but we'd like an automated way to handle this going forward.  Please document how one acquires and then uploads the SDK to tooltool for now.
https://github.com/mozilla/build-puppet/blob/9fe765367a144baf549ff76ac3f8a440603bf4b3/modules/packages/manifests/xcode.pp#L31
            # Different versions of OS X use different versions of Xcode.  And
            # every version of Xcode is its own unique little hell.  Of course,
            # we can't distribute Xcode, but the instructions here should be
            # sufficient to reproduce what we've done.  Note that Apple
            # frequently deletes "old" stuff, so you may not be able to find
            # some of the source binaries anymore.  Sorry.  Apple sucks.

Basically, I wouldn't suggest trying to automate it -- the translation of "unique little hell" is "new and different".  For the existing versions, it probably makes sense to copy the notes in that file, and then just amend those instructions for later versions.
Ted, is this documented in some place that someone interested in upgrading the SDKs used for cross-compilation might find it?
Flags: needinfo?(ted)
It's not. Essentially all I did to generate these was locate an SDK on my Mac and tar that directory up. We could certainly write a little script (or mach command, even) to make that more straightforward.
Flags: needinfo?(ted)
I think just writing it down would be enough, so the next person isn't left wondering.
That's totally reasonable. Is there an existing place where this documentation would fit? We're not very good about writing down how we produced tooltool artifacts.
The best I can think of is, somewhere in the code that a dev is most likely to trip across when looking for this -- maybe a comment in a mozocnfig?  Sadly, the JSON manifests do not permit a comment :(
Added a useful comment in the mozconfig. Let's leave this open to track adding a mach command like we have for Visual C++ packages.
Assignee: nobody → ted
Status: NEW → ASSIGNED
Keywords: leave-open
Comment on attachment 8817268 [details]
bug 1286331 - document how to generate an SDK tarball.  (DONTBUILD)

https://reviewboard.mozilla.org/r/97632/#review97948
Attachment #8817268 - Flags: review?(dustin) → review+
Pushed by tmielczarek@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8137e66c6c18
document how to generate an SDK tarball. r=dustin (DONTBUILD)
Component: Task Configuration → mach
Product: Taskcluster → Core
Product: Core → Firefox Build System
Component: Mach Core → General
The leave-open keyword is there and there is no activity for 6 months.
:ted, maybe it's time to close this bug?
Flags: needinfo?(ted)
Yeah, that's fine.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(ted)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.