1,500 instances of "Couldn't convert chrome URL: chrome://branding/locale/brand.properties" emitted from none during linux64 debug testing

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: cubeb
P2
normal
Rank:
29
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: erahm, Assigned: padenot)

Tracking

(Blocks: 1 bug)

Trunk
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

> 1478 Couldn't convert chrome URL: chrome://branding/locale/brand.properties

This debug printf [1] shows up in the following test suites:

>     88 - [TC] Linux64 cppunit Cpp
>     84 - [TC] Linux64 mochitest-chrome-1 c1
>     64 - [TC] Linux64 mochitest-chrome-3 c3
>     62 - [TC] Linux64 mochitest-clipboard cl
>     58 - [TC] Linux64 mochitest-clipboard-e10s cl
>     38 - [TC] Linux64 mochitest-chrome-2 c2
>     36 - [TC] Linux64 mochitest-browser-chrome-e10s-5 bc5
>     36 - [TC] Linux64 mochitest-browser-chrome-e10s-1 bc1
>     36 - [TC] Linux64 mochitest-browser-chrome-e10s-2 bc2
>     34 - [TC] Linux64 mochitest-browser-chrome-e10s-3 bc3
>     34 - [TC] Linux64 mochitest-browser-chrome-4 bc4
>     34 - [TC] Linux64 mochitest-plain-e10s-5 5
>     34 - [TC] Linux64 mochitest-browser-chrome-5 bc5
>     34 - [TC] Linux64 mochitest-6 6
>     32 - [TC] Linux64 mochitest-browser-chrome-6 bc6
>     32 - [TC] Linux64 mochitest-browser-chrome-e10s-4 bc4
>     30 - [TC] Linux64 mochitest-4 4
>     30 - [TC] Linux64 mochitest-plain-e10s-9 9
>     30 - [TC] Linux64 mochitest-10 10
>     28 - [TC] Linux64 mochitest-7 7
>     28 - [TC] Linux64 mochitest-8 8
>     28 - [TC] Linux64 mochitest-9 9
>     28 - [TC] Linux64 mochitest-3 3
>     28 - [TC] Linux64 mochitest-5 5
>     28 - [TC] Linux64 mochitest-browser-chrome-2 bc2
>     28 - [TC] Linux64 mochitest-plain-e10s-3 3
>     28 - [TC] Linux64 mochitest-plain-e10s-2 2
>     28 - [TC] Linux64 mochitest-1 1
>     26 - [TC] Linux64 mochitest-plain-e10s-4 4
>     26 - [TC] Linux64 mochitest-browser-chrome-1 bc1
>     26 - [TC] Linux64 mochitest-plain-e10s-10 10
>     26 - [TC] Linux64 mochitest-2 2
>     26 - [TC] Linux64 mochitest-plain-e10s-6 6
>     26 - [TC] Linux64 mochitest-plain-e10s-7 7
>     26 - [TC] Linux64 mochitest-plain-e10s-8 8
>     26 - [TC] Linux64 mochitest-plain-e10s-1 1
>     22 - [TC] Linux64 mochitest-browser-chrome-3 bc3
>     18 - [TC] Linux64 mochitest-media mda
>     18 - [TC] Linux64 mochitest-media-e10s mda
>     14 - [TC] Linux64 mochitest-gpu-e10s gpu
>     14 - [TC] Linux64 mochitest-gpu gpu
>     10 - [TC] Linux64 mochitest-gl gl
>     10 - [TC] Linux64 mochitest-devtools-chrome-8 dt8
>     10 - [TC] Linux64 mochitest-gl-e10s gl
>     10 - [TC] Linux64 mochitest-devtools-chrome-6 dt6
>      8 - [TC] Linux64 mochitest-devtools-chrome-2 dt2
>      8 - [TC] Linux64 mochitest-devtools-chrome-1 dt1
>      8 - [TC] Linux64 mochitest-devtools-chrome-3 dt3
>      8 - [TC] Linux64 mochitest-devtools-chrome-5 dt5
>      6 - [TC] Linux64 mochitest-devtools-chrome-7 dt7
>      6 - [TC] Linux64 mochitest-devtools-chrome-4 dt4
>      4 - [TC] Linux64 Debug B
>      2 - [TC] Linux64 mochitest-a11y a11y
>      2 - [TC] Linux64 mochitest-devtools-chrome-9 dt9
>      2 - Static Checking Build S
>      2 - [TC] Linux64 mochitest-browser-chrome-e10s-6 bc6
>      2 - [TC] Linux64 mochitest-devtools-chrome-10 dt10
>      2 - [TC] Linux64 mochitest-browser-chrome-e10s-7 bc7
>      2 - [TC] Linux64 gtest GTest
>      2 - [TC] Linux64 mochitest-browser-chrome-7 bc7
>      2 - [TC] Linux64 mochitest-jetpack JP

It shows up in 106 tests. A few of the most prevalent:

>    752 -        Shutdown
>    508 - [e10s] Shutdown
>      2 -        TestStartupCache
>      2 -        toolkit/content/tests/browser/browser_content_url_annotation.js
>      2 -        test_IHistory
>      2 -        TestObserverArray
>      2 -        dom/imptests/html/webgl/test_compressedTexSubImage2D.html
>      2 -        devtools/client/debugger/test/mochitest/browser_dbg_variables-view-popup-14.js
>      2 -        widget/tests/test_bug565392.html
>      2 - [e10s] dom/xbl/test/test_bug946815.html

[1] https://dxr.mozilla.org/mozilla-central/rev/88bebcaca249aeaca9197382e89d35b02be8292e/chrome/nsChromeProtocolHandler.cpp#144
Overall there's 2,090 of these types of warnings during testing:

> $ log_spam --warning-re "^Couldn't convert chrome URL:" 94c926911767
> Using cached data
> Top 40 Warnings
> ===============
>   1478 Couldn't convert chrome URL: chrome://branding/locale/brand.properties
>    408 Couldn't convert chrome URL: chrome://foo/skin/icon.png
>     80 Couldn't convert chrome URL: chrome://mochitests/tests/SimpleTest/test.css
>     40 Couldn't convert chrome URL: chrome://mochikit/contents/tests/SimpleTest/test.css
>     32 Couldn't convert chrome URL: chrome://mochitests/tests/layout/style/test/chrome/match.png
>     16 Couldn't convert chrome URL: chrome://foo/skin/icon64.png
>     16 Couldn't convert chrome URL: chrome://foo/skin/icon264.png
>      8 Couldn't convert chrome URL: chrome://exta/locale/exta.dtd
>      4 Couldn't convert chrome URL: chrome:///browser/skin/
>      4 Couldn't convert chrome URL: chrome://myaddon/locale/mydialog.dtd
>      2 Couldn't convert chrome URL: chrome://foo/content/foo.xul
>      2 Couldn't convert chrome URL: chrome://navigator/content/navigator.css
> TOTAL WARNINGS: 2090
Bisected to bug 845648 [1].

This also correlates with (there's 2 warnings about the chrome URL and one about the program name):

> 739 WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file dom/media/CubebUtils.cpp, line 153

This warning [2] shows up in the following test suites:

>     44 - [TC] Linux64 cppunit Cpp
>     42 - [TC] Linux64 mochitest-chrome-1 c1
>     32 - [TC] Linux64 mochitest-chrome-3 c3
>     31 - [TC] Linux64 mochitest-clipboard cl
>     29 - [TC] Linux64 mochitest-clipboard-e10s cl
>     19 - [TC] Linux64 mochitest-chrome-2 c2
>     18 - [TC] Linux64 mochitest-browser-chrome-e10s-5 bc5
>     18 - [TC] Linux64 mochitest-browser-chrome-e10s-1 bc1
>     18 - [TC] Linux64 mochitest-browser-chrome-e10s-2 bc2
>     17 - [TC] Linux64 mochitest-browser-chrome-e10s-3 bc3
>     17 - [TC] Linux64 mochitest-browser-chrome-4 bc4
>     17 - [TC] Linux64 mochitest-plain-e10s-5 5
>     17 - [TC] Linux64 mochitest-browser-chrome-5 bc5
>     17 - [TC] Linux64 mochitest-6 6
>     16 - [TC] Linux64 mochitest-browser-chrome-6 bc6
>     16 - [TC] Linux64 mochitest-browser-chrome-e10s-4 bc4
>     15 - [TC] Linux64 mochitest-4 4
>     15 - [TC] Linux64 mochitest-plain-e10s-9 9
>     15 - [TC] Linux64 mochitest-10 10
>     14 - [TC] Linux64 mochitest-7 7
>     14 - [TC] Linux64 mochitest-8 8
>     14 - [TC] Linux64 mochitest-9 9
>     14 - [TC] Linux64 mochitest-3 3
>     14 - [TC] Linux64 mochitest-5 5
>     14 - [TC] Linux64 mochitest-browser-chrome-2 bc2
>     14 - [TC] Linux64 mochitest-plain-e10s-3 3
>     14 - [TC] Linux64 mochitest-plain-e10s-2 2
>     14 - [TC] Linux64 mochitest-1 1
>     13 - [TC] Linux64 mochitest-plain-e10s-4 4
>     13 - [TC] Linux64 mochitest-browser-chrome-1 bc1
>     13 - [TC] Linux64 mochitest-plain-e10s-10 10
>     13 - [TC] Linux64 mochitest-2 2
>     13 - [TC] Linux64 mochitest-plain-e10s-6 6
>     13 - [TC] Linux64 mochitest-plain-e10s-7 7
>     13 - [TC] Linux64 mochitest-plain-e10s-8 8
>     13 - [TC] Linux64 mochitest-plain-e10s-1 1
>     11 - [TC] Linux64 mochitest-browser-chrome-3 bc3
>      9 - [TC] Linux64 mochitest-media mda
>      9 - [TC] Linux64 mochitest-media-e10s mda
>      7 - [TC] Linux64 mochitest-gpu-e10s gpu
>      7 - [TC] Linux64 mochitest-gpu gpu
>      5 - [TC] Linux64 mochitest-gl gl
>      5 - [TC] Linux64 mochitest-devtools-chrome-8 dt8
>      5 - [TC] Linux64 mochitest-gl-e10s gl
>      5 - [TC] Linux64 mochitest-devtools-chrome-6 dt6
>      4 - [TC] Linux64 mochitest-devtools-chrome-2 dt2
>      4 - [TC] Linux64 mochitest-devtools-chrome-1 dt1
>      4 - [TC] Linux64 mochitest-devtools-chrome-3 dt3
>      4 - [TC] Linux64 mochitest-devtools-chrome-5 dt5
>      3 - [TC] Linux64 mochitest-devtools-chrome-7 dt7
>      3 - [TC] Linux64 mochitest-devtools-chrome-4 dt4
>      2 - [TC] Linux64 Debug B
>      1 - [TC] Linux64 mochitest-a11y a11y
>      1 - [TC] Linux64 mochitest-devtools-chrome-9 dt9
>      1 - Static Checking Build S
>      1 - [TC] Linux64 mochitest-browser-chrome-e10s-6 bc6
>      1 - [TC] Linux64 mochitest-devtools-chrome-10 dt10
>      1 - [TC] Linux64 mochitest-browser-chrome-e10s-7 bc7
>      1 - [TC] Linux64 gtest GTest
>      1 - [TC] Linux64 mochitest-browser-chrome-7 bc7
>      1 - [TC] Linux64 mochitest-jetpack JP

It shows up in 106 tests. A few of the most prevalent:

>    376 -        Shutdown
>    254 - [e10s] Shutdown
>      1 -        TestStartupCache
>      1 -        toolkit/content/tests/browser/browser_content_url_annotation.js
>      1 -        test_IHistory
>      1 -        TestObserverArray
>      1 -        dom/imptests/html/webgl/test_compressedTexSubImage2D.html
>      1 -        devtools/client/debugger/test/mochitest/browser_dbg_variables-view-popup-14.js
>      1 -        widget/tests/test_bug565392.html
>      1 - [e10s] dom/xbl/test/test_bug946815.html


[1] https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ed8f19f31b54a554d04ae5b23e154adad5fc3e64&tochange=658c25a8405745e52f72f1437bd14a5339e4ca9d
[2] https://hg.mozilla.org/mozilla-central/annotate/94c926911767/dom/media/CubebUtils.cpp#l153
Blocks: 845648
Component: General → Audio/Video: cubeb
Flags: needinfo?(padenot)
(Assignee)

Comment 3

a year ago
yeah, I can repro, looks like this code is wrong when running with e10s enabled.
Assignee: nobody → padenot
Flags: needinfo?(padenot)
(In reply to Paul Adenot (:padenot) from comment #3)
> yeah, I can repro, looks like this code is wrong when running with e10s
> enabled.

FWIW the logs seems to indicate it's happening on both e10s and non-e10s.

Updated

a year ago
Rank: 29
Priority: -- → P2
(Assignee)

Comment 5

a year ago
Must be timing related then.
(Assignee)

Comment 6

a year ago
Created attachment 8772407 [details]
Bug 1286341 - Initialize sBrandName before layout startup when initializing the cubeb.

We call `cubeb_init` quite early these days because the sandbox is enabled
a short time after, so we'd call GetCubebContext before InitBrandName, thus
showing the warning.

Review commit: https://reviewboard.mozilla.org/r/65228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65228/
Attachment #8772407 - Flags: review?(rjesup)
Comment on attachment 8772407 [details]
Bug 1286341 - Initialize sBrandName before layout startup when initializing the cubeb.

https://reviewboard.mozilla.org/r/65228/#review62252
Attachment #8772407 - Flags: review?(rjesup) → review+

Comment 8

a year ago
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/329cbf4e5edb
Initialize sBrandName before layout startup when initializing the cubeb. r=jesup

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/329cbf4e5edb
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.