1286357 - "Open Container Tab" icon under toolbar opens tabs decorated as containers when feature is disabled

Status: RESOLVED DUPLICATE of bug 1279297

(Core :: DOM: Security, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

Because of bug # 1279297, users can get into a situation where the tabs are still being decorated with the container UI while the feature is disabled. This might confuse users as containers should have been disabled, yet the "Open Container Tab" icon is still present and is still opening decorated container tabs. Once the user restarts the browser, the icon will disappear.

STR:

* launch the latest version of nightly
* move the "Open Container Tab" icon into the fx toolbar from the customization menu
* go into about:config and disable containers via privacy.userContext.enabled;false
* click on the "Open Container Tab" and click on the personal container
* you'll notice that the new tab has all the container UI decorations even though it's disabled
* load a website within the new tab that was opened via the "Open Container Tab" icon on the toolbar

You'll notice that the cookies are NOT using containers yet the tab is still using all the UI decorations which might confuse some users.

Comment 1

[Tanvi Vyas[:tanvi]]

We need to check the flag for UI decoration so that bugs like this don't happen in the future.

Comment 2

[Tanvi Vyas[:tanvi]]

Q. What happens when a user has an open container tab and then disables containers?
A. Prompt the user to close their container tabs before they can change the pref. OR prompt the user that Firefox is going to close their container tabs when the pref is flipped.

Comment 3

[Andrea Marchesini [:baku]]

> A. Prompt the user to close their container tabs before they can change the
> pref. OR prompt the user that Firefox is going to close their container tabs
> when the pref is flipped.

Now we have about:preferences with containers support. We should file a bug for this particular issue.
The issue described by this bug, is fixed by bug 1279297.