Closed Bug 1286376 Opened 3 years ago Closed 3 years ago

Intermittent dom/security/test/general/test_contentpolicytype_targeted_link_iframe.html | called finish() multiple times

Categories

(Core :: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ckerschb)

References

Details

(Keywords: intermittent-failure, Whiteboard: [domsecurity-active])

Attachments

(1 file)

Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Whiteboard: [domsecurity-active]
Olli, potentially 'shouldLoad' is called again even after the test has finished. Since we only update testCounter if it equals the EXPECTED_URL it remains the same and we call finish() multiple times. I should have seen that in the first place, sorry about that.

Let's only call finish() if we are already within that 'if'-branch - thanks!
Flags: needinfo?(ckerschb)
Attachment #8770422 - Flags: review?(bugs)
Attachment #8770422 - Flags: review?(bugs) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b47b8d147eb
Do not call finish multiple times within test_contentpolicytype_targeted_link_iframe.html. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6b47b8d147eb
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.