1286376 - Intermittent dom/security/test/general/test_contentpolicytype_targeted_link_iframe.html | called finish() multiple times

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=31669745&repo=mozilla-inbound

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1468348046/mozilla-inbound_win7_ix-debug_test-mochitest-3-bm109-tests1-windows-build149.txt.gz

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=749004283a017f8a3e7962a89b85b5235b57a8da&bugfiler&filter-tier=1&filter-searchStr=c1cf85774f1f48e31cb8459f6428468d631b791b&tochange=d60c87d89619d97f20a4443c3357f1baffba3cea&selectedJob=31673368

Bug 1255240 landed soon before the first instance of this I noticed.

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

Attachment: bug_1286376_do_not_call_finish_multiple_times.patch

Olli, potentially 'shouldLoad' is called again even after the test has finished. Since we only update testCounter if it equals the EXPECTED_URL it remains the same and we call finish() multiple times. I should have seen that in the first place, sorry about that.

Let's only call finish() if we are already within that 'if'-branch - thanks!

Comment 3

[Intermittent Failures Robot]

20 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 7
* fx-team: 7
* autoland: 5
* try: 1

Platform breakdown:
* windows7-32: 15
* linux64: 4
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1286376&startday=2016-07-13&endday=2016-07-13&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b47b8d147eb
Do not call finish multiple times within test_contentpolicytype_targeted_link_iframe.html. r=smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b47b8d147eb

Comment 6

[Intermittent Failures Robot]

74 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 43
* autoland: 15
* fx-team: 9
* mozilla-central: 6
* try: 1

Platform breakdown:
* windows7-32: 66
* linux64: 5
* windows8-64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1286376&startday=2016-07-11&endday=2016-07-17&tree=all