Closed Bug 1286376 Opened 6 years ago Closed 6 years ago
_contentpolicytype _targeted _link _iframe .html | called finish() multiple times
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=749004283a017f8a3e7962a89b85b5235b57a8da&bugfiler&filter-tier=1&filter-searchStr=c1cf85774f1f48e31cb8459f6428468d631b791b&tochange=d60c87d89619d97f20a4443c3357f1baffba3cea&selectedJob=31673368 Bug 1255240 landed soon before the first instance of this I noticed.
Depends on: 1255240
Assignee: nobody → ckerschb
Status: NEW → ASSIGNED
Olli, potentially 'shouldLoad' is called again even after the test has finished. Since we only update testCounter if it equals the EXPECTED_URL it remains the same and we call finish() multiple times. I should have seen that in the first place, sorry about that. Let's only call finish() if we are already within that 'if'-branch - thanks!
Attachment #8770422 - Flags: review?(bugs)
Attachment #8770422 - Flags: review?(bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b47b8d147eb Do not call finish multiple times within test_contentpolicytype_targeted_link_iframe.html. r=smaug
You need to log in before you can comment on or make changes to this bug.