[TSF] Don't put \r\n directly to log file

RESOLVED FIXED in Firefox 50

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla50
All
Windows
inputmethod
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

When I'm debugging, \r\n are very annoying to breaking lines in the log file.

We should replace them (and \t, perhaps, more?) with "\\n", etc.
Created attachment 8770605 [details]
Bug 1286489 TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly

Review commit: https://reviewboard.mozilla.org/r/64038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64038/
Attachment #8770605 - Flags: review?(m_kato)
Comment on attachment 8770605 [details]
Bug 1286489 TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly

https://reviewboard.mozilla.org/r/64038/#review61180
Attachment #8770605 - Flags: review?(m_kato) → review+

Comment 4

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/369cab5b9f2e
TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly r=m_kato

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/369cab5b9f2e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.