1286489 - [TSF] Don't put \r\n directly to log file

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

When I'm debugging, \r\n are very annoying to breaking lines in the log file.

We should replace them (and \t, perhaps, more?) with "\\n", etc.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae96f0dd48ec

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1286489 TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly

Review commit: https://reviewboard.mozilla.org/r/64038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64038/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8770605 [details]
Bug 1286489 TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly

https://reviewboard.mozilla.org/r/64038/#review61180

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/369cab5b9f2e
TSFTextStore.cpp and ContentCache.cpp shouldn't put \n, \r and \t to log file directly r=m_kato

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/369cab5b9f2e