Closed Bug 1286506 Opened 3 years ago Closed 3 years ago

Be more cautious about shrinking the nursery

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

bug1286506-reduce-nursery-resizing
2.71 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
Looking at benchmark output I see the nursery growing and shrinking a lot.  Often there will be a collection with a low promotion rate that causes the nursery to shrink followed by a collection with a high promotion rate that causes it to grow again.  It would be good to stop it bouncing around like this.
The patch only shrinks the nursery when the promotion rate is below the threshold for two consecutive collections.  This seems to be quite effective at reducing the bouncing.
Attachment #8770495 - Flags: review?(terrence)
Attachment #8770495 - Flags: review?(terrence) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ad8e878aef7
Be more cautious about shrinking the nursery r=terrence
https://hg.mozilla.org/mozilla-central/rev/6ad8e878aef7
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.