1286511 - Win10 Start Menu Tile wrong color

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Start Menu Tile background changed color from 'Grey' to 'Light bluish' color

See discussion in the two blocking bugs relative to this matter.

Comment 1

[Katie Broida [:ktbee]]

Attachment: Bug 1286511 - Fixes incorrect start menu tile color by removing VisualElementsManfiest.xml

This patch removes the VisualElementsManifest.xml file, which I found was breaking the start menu tile for some Windows 10 computers. Without it, firefox.VisualElementsManifest.xml still customizes Nightly's start menu tile for some Windows 10 computers. For others, it leaves the tile unaffected and the default background color and icon image show.

Review commit: https://reviewboard.mozilla.org/r/64258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64258/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8770976 [details]
Bug 1286511 - Fixes incorrect start menu tile color by removing VisualElementsManfiest.xml

https://reviewboard.mozilla.org/r/64258/#review61298

r=me for the file removal. I added rstrong as a reviewer since this touches the installer.

Do we need to do anything extra to have the installer remove this file if it was already installed? This hasn't left the Nightly channel yet so it won't affect DevChannel, Beta, or Release.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8770976 [details]
Bug 1286511 - Fixes incorrect start menu tile color by removing VisualElementsManfiest.xml

https://reviewboard.mozilla.org/r/64258/#review61306

Looks good and I visually verified that these build changes should do the right thing for our build packaging code.

Comment 4

[Robert Strong (they/them - no direct email)]

I have a patch to land and will land this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36ea792c434b
Fixes incorrect start menu tile color by removing VisualElementsManfiest.xml. r=jaws, r=rstrong

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/36ea792c434b

Comment 7

[Saheda Reza [:Antora]]

I have reproduced this on Firefox nightly according to(2016-07-13)

Fixing bug is verified on Latest Nightly--Build ID: (20160908030434), User Agent: Mozilla/5.0 (Windows NT 10.0; rv:51.0) Gecko/20100101 Firefox/51.0


Tested OS-- Windows10 32bit

Comment 8

[Saheda Reza [:Antora]]

Also ,
Fixing bug is verified on Latest Developer Edition-- Build ID:(20160909004004),User Agent: Mozilla/5.0 (Windows NT 10.0; rv:50.0) Gecko/20100101 Firefox/50.0

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!