Closed Bug 1286520 Opened 8 years ago Closed 8 years ago

Update urls stored in default preferences in about:config / all-thunderbirds.js to https

Categories

(Thunderbird :: Preferences, defect)

51 Branch
defect
Not set
normal

Tracking

(thunderbird51 fixed)

RESOLVED FIXED
Thunderbird 51.0
Tracking Status
thunderbird51 --- fixed

People

(Reporter: aryx, Assigned: aryx)

Details

Attachments

(1 file, 1 obsolete file)

There are some urls in the default preferences which still use http instead of https.
Attached patch patch, v1 (obsolete) — Splinter Review
Kept http for the two getthunderbird.com preferences because the server doesn't support https. Filed bug 1286518 for that.
Attachment #8770513 - Flags: review?(mkmelin+mozilla)
Attached patch patch, v2Splinter Review
Dropped the obsolete preference mailnews.migration.header_addons_url which got added as part of bug 516884. The feature got removed in bug 735524.
Attachment #8770513 - Attachment is obsolete: true
Attachment #8770513 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8770865 [details] [diff] [review]
patch, v2

Review of attachment 8770865 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin for this and changing over getthunderbird.com to https once that works
Attachment #8770865 - Flags: review+
https://hg.mozilla.org/comm-central/rev/2d98b9270327
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
Version: unspecified → 51 Branch
I heard we could like to resurrect some form of migration/upgrade assistant.
I think you'd have to have a pretty compelling use case for something like that.
I think is was brought up in the Correspondents column bugs.
Yeah, but not as a page on server, but maybe just a plain first-run dialog which would just present some new options and set pref accordingly.
That's what used to exist. It's really terrible from a resourcing perspective though - all in all the work that was put into that part I'd say was way disproportional to anything good it might have done. And it would really have made no difference in the Correspondents case...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: