Closed Bug 1286524 Opened 8 years ago Closed 8 years ago

Fix settings for BASKET_NDA_NEWSLETTER

Categories

(Participation Infrastructure :: Phonebook, defect)

Product:
Participation Infrastructure
Component:
Phonebook
Version:
2016-7.4
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: nemo-yiannis, Assigned: nemo-yiannis)

References

Details

(Whiteboard: [qa-]) 

We should replace BASKET_NDA_NEWSLETTER settings entry with the correct value. Settings should change to:

BASKET_NDA_NEWSLETTER = 'mozillians-nda'

instead of:

BASKET_NDA_NEWSLETTER = 'nda-mozillians'
Blocks: 1282444
Let's also cleanup stale references to BASKET_NEWSLETTER.
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/007b85ff471f93ada9c860fc2ae09a397091fcf7
[Fix bug 1286524] Fix BASKET_NDA_NEWSLETTER config entry.

* Cleanup stale references to BASKET_NEWSLETTER.

https://github.com/mozilla/mozillians/commit/5f0af7384b447d9ab667e466659f0492142a9c5d
Merge pull request #1480 from johngian/1286524

[Fix bug 1286524] Fix BASKET_NDA_NEWSLETTER config entry.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Version: other → next
Assignee: nobody → jgiannelos
Verified on stage:

* On basket celery task failure we are getting notifications
* Sentry issue has no related events after this fix landed on stage
Status: RESOLVED → VERIFIED
Previous comment is referring to another bug.

Marking this one as qa-. Verified that the new ``BASKET_NDA_NEWSLETTER`` value is listed in the response from this basket endpoint:

curl -XGET https://basket.mozilla.org/news/newsletters/
Whiteboard: [qa-]
Version: next → 2016-7.4
You need to log in before you can comment on or make changes to this bug.