Closed Bug 1286548 Opened 3 years ago Closed 3 years ago

Add an optional argument to isExposedConditionally method for SecureContext

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: shawnjohnjr, Assigned: edgar)

References

Details

Attachments

(1 file)

Add an optional argument to isExposedConditionally method for SecureContext. Follow-up Bug 1267941, the current WebIDL.py raises error, when [SecureContext] and [NoInterfaceObject] exists at the same time. [SecureContext] does two jobs: conditional exposure of the interface _and_ conditional exposure of the interface members.  The former job makes no sense for [NoInterfaceObject] things, but the latter does. We should add an optional to |isExposedConditionally| to return false.


if (self.isExposedConditionally()and                                   
    not self.hasInterfaceObject() and                                   
    not self.isNavigatorProperty()):                                    
    raise WebIDLError("Interface with no interface object is "          
                      "exposed conditionally",                          
                       [self.location])
Assignee: nobody → echen
Comment on attachment 8771229 [details]
Bug 1286548 - SecureContext makes sense for interface with NoInterfaceObject, since it is also propagated to interface members;

https://reviewboard.mozilla.org/r/64486/#review61442

r=me.  Thank you!
Attachment #8771229 - Flags: review?(bzbarsky) → review+
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cefce05d01d
SecureContext makes sense for interface with NoInterfaceObject, since it is also propagated to interface members; r=bz
https://hg.mozilla.org/mozilla-central/rev/4cefce05d01d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.