1286548 - Add an optional argument to isExposedConditionally method for SecureContext

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Add an optional argument to isExposedConditionally method for SecureContext. Follow-up Bug 1267941, the current WebIDL.py raises error, when [SecureContext] and [NoInterfaceObject] exists at the same time. [SecureContext] does two jobs: conditional exposure of the interface _and_ conditional exposure of the interface members.  The former job makes no sense for [NoInterfaceObject] things, but the latter does. We should add an optional to |isExposedConditionally| to return false.


if (self.isExposedConditionally()and                                   
    not self.hasInterfaceObject() and                                   
    not self.isNavigatorProperty()):                                    
    raise WebIDLError("Interface with no interface object is "          
                      "exposed conditionally",                          
                       [self.location])

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1286548 - SecureContext makes sense for interface with NoInterfaceObject, since it is also propagated to interface members;

Review commit: https://reviewboard.mozilla.org/r/64486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64486/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8771229 [details]
Bug 1286548 - SecureContext makes sense for interface with NoInterfaceObject, since it is also propagated to interface members;

https://reviewboard.mozilla.org/r/64486/#review61442

r=me.  Thank you!

Comment 3

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=39d7834b0ee4&group_state=expanded&filter-tier=1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cefce05d01d
SecureContext makes sense for interface with NoInterfaceObject, since it is also propagated to interface members; r=bz

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4cefce05d01d