Closed Bug 128663 Opened 22 years ago Closed 22 years ago

"Exit" menuitem doesn't work

Categories

(Other Applications :: DOM Inspector, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hwaara, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

The "Exit" menuitem in Inspector doesn't work. Boris found this bug...

Basically, the overlays were screwing us. (I'm too tired to understand my own 
fix. :-)
Attached patch Gimme some review lovin', baby! (obsolete) — Splinter Review
Comment on attachment 72268 [details] [diff] [review]
Gimme some review lovin', baby!

r=bzbarsky
Attachment #72268 - Flags: review+
Comment on attachment 72268 [details] [diff] [review]
Gimme some review lovin', baby!

sr=hewitt
Attachment #72268 - Flags: superreview+
Comment on attachment 72268 [details] [diff] [review]
Gimme some review lovin', baby!

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72268 - Flags: approval+
fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
sorry... now "close" does not work, though "quit" works dandy.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh man, this is such a mess.  Boris, feel free to take this if you're
interested. I have to many other more important 1.0-bugs to work on. :-/
I have no time for this either...
hewitt originally wrote this code, maybe he understands it better than I. :-(
Assignee: hwaara → hewitt
Status: REOPENED → NEW
Comment on attachment 72268 [details] [diff] [review]
Gimme some review lovin', baby!

obsoleting old patch.
Attachment #72268 - Attachment is obsolete: true
*** Bug 137310 has been marked as a duplicate of this bug. ***
Attached patch This fixes it...Splinter Review
hwaara?  hewitt? reviews?
Comment on attachment 79098 [details] [diff] [review]
This fixes it...

r=hwaara if it works. :-)
Attachment #79098 - Flags: review+
Comment on attachment 79098 [details] [diff] [review]
This fixes it...

sr=hewitt
Attachment #79098 - Flags: superreview+
Taking to check in
Assignee: hewitt → bzbarsky
Comment on attachment 79098 [details] [diff] [review]
This fixes it...

a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #79098 - Flags: approval+
This was checked in on the trunk on Apr. 16.  Waiting for branch to open to
check in there.
fixed on branch
Status: NEW → RESOLVED
Closed: 22 years ago22 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
Product: Core → Other Applications
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: