Closed
Bug 1286663
Opened 7 years ago
Closed 7 years ago
Convert thumbnail event to native method
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(5 files)
5.09 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
14.29 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
13.46 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
3.88 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
15.65 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Convert the THUMBNAIL event in GeckoEvent to native method call in ThumbnailHelper, and also move the thumbnail capture implementation from AndroidBridge to a ThumbnailHelper-specific file.
Assignee | ||
Comment 1•7 years ago
|
||
Add a wrapper class for ByteBuffer and its associated calls in JNI.
Attachment #8772075 -
Flags: review?(snorp)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8772076 -
Flags: review+
Assignee | ||
Comment 3•7 years ago
|
||
Add and use a request thumbnail native method call in ThumbnailHelper, instead of using the THUMBNAIL event in GeckoEvent.
Attachment #8772077 -
Flags: review?(snorp)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8772078 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
Remove the now-obsolete THUMBNAIL event from GeckoEvent, as well as its implementations in nsAppShell and AndroidBridge.
Attachment #8772079 -
Flags: review?(snorp)
Attachment #8772075 -
Flags: review?(snorp) → review+
Comment on attachment 8772077 [details] [diff] [review] Add request thumbnail native method to ThumbnailHelper (v1) Review of attachment 8772077 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/android/ThumbnailHelper.h @@ +25,5 @@ > +#include "mozilla/Preferences.h" > + > +namespace mozilla { > + > +class ThumbnailHelper final This is an awful lot of code to put into a header. Consider putting most of the impl in a cpp file.
Attachment #8772077 -
Flags: review?(snorp) → review+
Attachment #8772079 -
Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f623f6ccca25 Add JNI wrapper class for ByteBuffer; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd055ed9366 Update existing code using ByteBuffer; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/142caeafd119 Add request thumbnail native method to ThumbnailHelper; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8cf0d3f2c2 Update auto-generated bindings; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a07729a34c Remove THUMBNAIL event from GeckoEvent; r=snorp
Comment 8•7 years ago
|
||
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=32314092&repo=mozilla-inbound
Flags: needinfo?(nchen)
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6713d9c84fff Backed out changeset d8a07729a34c https://hg.mozilla.org/integration/mozilla-inbound/rev/c774aed886fd Backed out changeset 3f8cf0d3f2c2 https://hg.mozilla.org/integration/mozilla-inbound/rev/28f30533c635 Backed out changeset f623f6ccca25 for another bustage on android on a CLOSED TREE
Comment 10•7 years ago
|
||
Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4cf2ae920be0 Backed out changeset 142caeafd119 https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9f2a1d387e Backed out changeset 7cd055ed9366 for android bustage on a CLOSED TREE
Comment 11•7 years ago
|
||
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c8a8de530e65 Add JNI wrapper class for ByteBuffer; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/a9946d087a15 Update existing code using ByteBuffer; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/74bee84b4e04 Add request thumbnail native method to ThumbnailHelper; r=snorp https://hg.mozilla.org/integration/mozilla-inbound/rev/ac00f838d3dc Update auto-generated bindings; r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/842f08286adf Remove THUMBNAIL event from GeckoEvent; r=snorp
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c8a8de530e65 https://hg.mozilla.org/mozilla-central/rev/a9946d087a15 https://hg.mozilla.org/mozilla-central/rev/74bee84b4e04 https://hg.mozilla.org/mozilla-central/rev/ac00f838d3dc https://hg.mozilla.org/mozilla-central/rev/842f08286adf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•1 year ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•