1286663 - Convert thumbnail event to native method

Status: RESOLVED FIXED

(Core :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Convert the THUMBNAIL event in GeckoEvent to native method call in ThumbnailHelper, and also move the thumbnail capture implementation from AndroidBridge to a ThumbnailHelper-specific file.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add JNI wrapper class for ByteBuffer (v1)

Add a wrapper class for ByteBuffer and its associated calls in JNI.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update existing code using ByteBuffer

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add request thumbnail native method to ThumbnailHelper (v1)

Add and use a request thumbnail native method call in ThumbnailHelper,
instead of using the THUMBNAIL event in GeckoEvent.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Update auto-generated bindings

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove THUMBNAIL event from GeckoEvent (v1)

Remove the now-obsolete THUMBNAIL event from GeckoEvent, as well as its
implementations in nsAppShell and AndroidBridge.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8772077 [details] [diff] [review]
Add request thumbnail native method to ThumbnailHelper (v1)

Review of attachment 8772077 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/ThumbnailHelper.h
@@ +25,5 @@
> +#include "mozilla/Preferences.h"
> +
> +namespace mozilla {
> +
> +class ThumbnailHelper final

This is an awful lot of code to put into a header. Consider putting most of the impl in a cpp file.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f623f6ccca25
Add JNI wrapper class for ByteBuffer; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd055ed9366
Update existing code using ByteBuffer; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/142caeafd119
Add request thumbnail native method to ThumbnailHelper; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8cf0d3f2c2
Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a07729a34c
Remove THUMBNAIL event from GeckoEvent; r=snorp

Comment 8

[Carsten Book [:Tomcat]]

backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=32314092&repo=mozilla-inbound

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6713d9c84fff
Backed out changeset d8a07729a34c 
https://hg.mozilla.org/integration/mozilla-inbound/rev/c774aed886fd
Backed out changeset 3f8cf0d3f2c2 
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f30533c635
Backed out changeset f623f6ccca25 for another bustage on android on a CLOSED TREE

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cf2ae920be0
Backed out changeset 142caeafd119 
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9f2a1d387e
Backed out changeset 7cd055ed9366 for android bustage on a CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8a8de530e65
Add JNI wrapper class for ByteBuffer; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9946d087a15
Update existing code using ByteBuffer; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/74bee84b4e04
Add request thumbnail native method to ThumbnailHelper; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac00f838d3dc
Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/842f08286adf
Remove THUMBNAIL event from GeckoEvent; r=snorp

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Repushed with clobber.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c8a8de530e65
https://hg.mozilla.org/mozilla-central/rev/a9946d087a15
https://hg.mozilla.org/mozilla-central/rev/74bee84b4e04
https://hg.mozilla.org/mozilla-central/rev/ac00f838d3dc
https://hg.mozilla.org/mozilla-central/rev/842f08286adf