Closed Bug 1286663 Opened 3 years ago Closed 3 years ago

Convert thumbnail event to native method

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Convert the THUMBNAIL event in GeckoEvent to native method call in ThumbnailHelper, and also move the thumbnail capture implementation from AndroidBridge to a ThumbnailHelper-specific file.
Add a wrapper class for ByteBuffer and its associated calls in JNI.
Attachment #8772075 - Flags: review?(snorp)
Add and use a request thumbnail native method call in ThumbnailHelper,
instead of using the THUMBNAIL event in GeckoEvent.
Attachment #8772077 - Flags: review?(snorp)
Remove the now-obsolete THUMBNAIL event from GeckoEvent, as well as its
implementations in nsAppShell and AndroidBridge.
Attachment #8772079 - Flags: review?(snorp)
Attachment #8772075 - Flags: review?(snorp) → review+
Comment on attachment 8772077 [details] [diff] [review]
Add request thumbnail native method to ThumbnailHelper (v1)

Review of attachment 8772077 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/ThumbnailHelper.h
@@ +25,5 @@
> +#include "mozilla/Preferences.h"
> +
> +namespace mozilla {
> +
> +class ThumbnailHelper final

This is an awful lot of code to put into a header. Consider putting most of the impl in a cpp file.
Attachment #8772077 - Flags: review?(snorp) → review+
Attachment #8772079 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f623f6ccca25
Add JNI wrapper class for ByteBuffer; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd055ed9366
Update existing code using ByteBuffer; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/142caeafd119
Add request thumbnail native method to ThumbnailHelper; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8cf0d3f2c2
Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a07729a34c
Remove THUMBNAIL event from GeckoEvent; r=snorp
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6713d9c84fff
Backed out changeset d8a07729a34c 
https://hg.mozilla.org/integration/mozilla-inbound/rev/c774aed886fd
Backed out changeset 3f8cf0d3f2c2 
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f30533c635
Backed out changeset f623f6ccca25 for another bustage on android on a CLOSED TREE
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cf2ae920be0
Backed out changeset 142caeafd119 
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9f2a1d387e
Backed out changeset 7cd055ed9366 for android bustage on a CLOSED TREE
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8a8de530e65
Add JNI wrapper class for ByteBuffer; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9946d087a15
Update existing code using ByteBuffer; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/74bee84b4e04
Add request thumbnail native method to ThumbnailHelper; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac00f838d3dc
Update auto-generated bindings; r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/842f08286adf
Remove THUMBNAIL event from GeckoEvent; r=snorp
Repushed with clobber.
Flags: needinfo?(nchen)
You need to log in before you can comment on or make changes to this bug.