1286673 - Test that sdk/event/dom.js does not leak windows

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Bug 1268898 fixed a window leak in sdk/event/dom.js.  Lets add a test to verify that this doesn't regress again in the future.

I'm planning to use the test helpers I'm adding in bug 1267693.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Test sdk/event/dom.js for leaks when used on a closed window. r=gabor

Since sdk/event/dom.js cleans itself up on "DOMWindowClose" it was a bit hard to find a case that leaked.  The best situation I could come up with is when the module is used on a window that is already closed.

This leaks without the fix from bug 1268898.  It does not leak with the fix applied.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d908afda7a5

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8771042 [details] [diff] [review]
Test sdk/event/dom.js for leaks when used on a closed window. r=gabor

Try build looks good.  This adds a test that catches the leak when we attach sdk/event/dom module to a closed window (fixed in bug 1268898).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/865803c7d5f8
Test sdk/event/dom.js for leaks when used on a closed window. r=gabor a=kwierso

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/865803c7d5f8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7f05d6e1e2f