Closed Bug 1286673 Opened 3 years ago Closed 3 years ago
Test that sdk/event/dom
.js does not leak windows
Bug 1268898 fixed a window leak in sdk/event/dom.js. Lets add a test to verify that this doesn't regress again in the future. I'm planning to use the test helpers I'm adding in bug 1267693.
Since sdk/event/dom.js cleans itself up on "DOMWindowClose" it was a bit hard to find a case that leaked. The best situation I could come up with is when the module is used on a window that is already closed. This leaks without the fix from bug 1268898. It does not leak with the fix applied. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d908afda7a5
Comment on attachment 8771042 [details] [diff] [review] Test sdk/event/dom.js for leaks when used on a closed window. r=gabor Try build looks good. This adds a test that catches the leak when we attach sdk/event/dom module to a closed window (fixed in bug 1268898).
Attachment #8771042 - Flags: review?(gkrizsanits)
Attachment #8771042 - Flags: review?(gkrizsanits) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/865803c7d5f8 Test sdk/event/dom.js for leaks when used on a closed window. r=gabor a=kwierso
You need to log in before you can comment on or make changes to this bug.