Closed Bug 1286732 Opened 9 years ago Closed 9 years ago

MDN revision dashboard has duplicate element ids

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Product:
developer.mozilla.org Graveyard
Component:
Code Cleanup
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jsx, Unassigned)

Details

(Whiteboard: [specification][type:bug])

What did you do? ================ 1. Visit https://developer.mozilla.org/en-US/dashboards/revisions What happened? ============== All Spam buttons have the same id 'spam-ham-button'. What should have happened? ========================== The MDN page on 'id' attribute [1] says "The id global attribute defines a unique identifier (ID) which must be unique in the whole document." I think we should stick to that. (But thanks for the spam buttons :)) [1] https://developer.mozilla.org/en/docs/Web/HTML/Global_attributes/id Is there anything else we should know? ======================================
Fixed by https://github.com/mozilla/kuma/pull/4023 Should be in production in a day or two.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.