1286791 - [Meta] Mortar performance and stability issues - PDF

Status: RESOLVED WONTFIX

(Firefox :: PDF Viewer, defect)

Description

[William Hsu [:whsu]]

The meta bug is for "PDF" performance issue of Mortar project
Please block this bug if the issue belongs to
1. Rendering performance
2. Low FPS rate
3. Scrolling performance
4. Zoom in/out performance
5. Algorithmic efficiency, e.g., text layer's algorithm.
6. etc.

Comment 1

[Bruce Sun [:brsun]]

Attachment: bug1286791_gecko.patch

This patch can be applied to Gecko 319080:215f96861176 (Sun Oct 23 20:04:42 2016 -0400).

Comment 2

[Bruce Sun [:brsun]]

I've also marked out all debug logs from flapper in this branch: https://github.com/mozilla/flapper.js/tree/bug1286791_pdf_performance

Comment 3

[Bruce Sun [:brsun]]

I would suggest to use an optimize build without debug capabilities for the performance testing.

i.e. make sure there are no such options in the |mozconfig| file while building Gecko:
# ac_add_options --enable-debug
# ac_add_options --disable-optimize

Comment 4

[Al Tsai [:atsai]]

Testing base:
» hg log -r 1dfe7eab1b82
changeset:   319532:1dfe7eab1b82
bookmark:    mortar-performance
parent:      319531:46a855ae9e4b
parent:      319425:f9f3cc95d728
user:        Phil Ringnalda <[e-mail]>
date:        Tue Oct 25 22:08:13 2016 -0700
summary:     Merge m-c to autoland

Comment 5

[Bruce Sun [:brsun]]

Attachment: x11_workaround.patch

Comment 6

[Bruce Sun [:brsun]]

Attachment: nolog_mortar.patch

Comment 7

[Bruce Sun [:brsun]]

Hi Al,

Please follow steps below to patch your Gecko and Mortar. Please refer to comment 3 as well to have a non-debug Gecko build.

Gecko patches:
 a. Use m-c with rev c27117f67fa3 (ref. bug 1291539 comment 6).
 b. Apply attachment 8812055 [details] [diff] (ref. bug 1291539 comment 7) to add the framework of JS-Plugin into Gecko.
 c. Apply attachment 8818505 [details] [diff] [review] (ref. comment 5) to workaround the compilation error on Ubuntu.
 d. Apply attachment 8813570 [details] [diff] [review] (ref. bug 1306576 comment 7) to fix memory leakages.

Mortar patches:
 a. Use the latest master of mortar (rev 1306576 on my machine).
 b. Apply attachment 8813571 [details] [diff] [review] (ref. bug 1306576 comment 8) to fix memory leakages.
 c. Apply attachment 8818506 [details] [diff] [review] (ref. comment 6) to disable all console logs.

Comment 8

[Bruce Sun [:brsun]]

By the way, please rebuild the RPC library again after Mortar has been patched.

Comment 9

[Joe Hildebrand [:jhildebrand] (UTC-6)]

I get that this bug is not for PDF.js, but it doesn't belong in Firefox:General.  Wontfix for 57, marking as a future potential feature.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

AFAIK, we aren't working on that anymore. Closing. please reopen if I am wrong.