Closed Bug 1286793 Opened 4 years ago Closed 4 years ago
Register visibility changes only when Media
Prefs::MDSMSuspend Background Video Enabled() is true
58 bytes, text/x-review-board-request
Don't pay for what you don't need. MDSM doesn't need to run VisibilityChanged() at all when the pref is off. The code is also simpler for there is only one place to check MediaPrefs::MDSMSuspendBackgroundVideoEnabled(). It also separates policy from mechanism so we have more flexibility to decide when to employ the mechanism (suspend-video-decoding).
Review commit: https://reviewboard.mozilla.org/r/64216/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64216/
Attachment #8770889 - Flags: review?(dglastonbury)
Assignee: nobody → jwwang
Priority: -- → P3
Comment on attachment 8770889 [details] Bug 1286793 - register visibility changes only when needed. https://reviewboard.mozilla.org/r/64216/#review61480 I like it.
Attachment #8770889 - Flags: review?(dglastonbury) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/694bbce74b30 register visibility changes only when needed. r=kamidphish
You need to log in before you can comment on or make changes to this bug.