1286821 - [Developer Edition] Triangle back button icon in linux theme when using hidpi

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jonathan Kingston [:jkt] he/him]

Attachment: Selection_242.png

The back icon in linux is broken showing a confusing triangle.

The icons are loaded here:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/toolbarbuttons.inc.css#181

It appears to be this line causing the issue (deleting it seems to fix it however I'm not sure if that is correct):
https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#228

Comment 1

[:Gijs (he/him)]

(In reply to Jonathan Kingston [:jkt] from comment #0)
> It appears to be this line causing the issue (deleting it seems to fix it
> however I'm not sure if that is correct):
> https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/
> devedition.inc.css#228

Judging by the blurry icons in your screenshot, you're using hidpi. We need to add a rule for the hidpi icon. See the patch from bug 1280133.

Comment 2

[Jonathan Kingston [:jkt] he/him]

Yeah my layout.css.devPixelsPerPx is set to 1.5.
As I say I think there is one already just perhaps the specificity of the selector mentioned is higher.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1286821 - fix devedition hidpi issue,

Review commit: https://reviewboard.mozilla.org/r/67396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67396/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/4b767c8f0236
fix devedition hidpi issue with back button icon, r=dao

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b767c8f0236

Comment 7

[Jonathan Chan [:jyc]]

This seems to be back in today's Nightly (2017-05-03) on Linux, except now it only occurs when the back button is clicked on.