Closed Bug 1286872 Opened 3 years ago Closed 3 years ago

Split out toolbox styles from toolbars.css

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox50 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Depends on 2 open bugs)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
(In reply to Brian Grinstead [:bgrins] from comment #14)
> Comment on attachment 8770988 [details] [diff] [review]
> Part 1: Move toolbox styles from toolbars.css to toolbox.css
> 
> Review of attachment 8770988 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks fine but can you move this into a separate bug that blocks Bug
> 1285745 instead of doing it here?
> 
> ::: devtools/client/themes/toolbox.css
> @@ +2,5 @@
> >  /* This Source Code Form is subject to the terms of the Mozilla Public
> >   * License, v. 2.0. If a copy of the MPL was not distributed with this
> >   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> >  
> > +.theme-light, .theme-dark {
> 
> Can you make this :root instead?  Just in case a new variable gets added
> that doesn't also get added to firebug at least there will be a default
> value.
Done.

> @@ +295,3 @@
> >  
> >  #command-button-paintflashing::before {
> > +  background-image: var(--command-paintflashing-image);
> 
> What changed on these lines?
I've fixed up the indentation to use 2 spaces. Should be more obvious now that I've pushed to MozReview.
Comment on attachment 8770996 [details]
Bug 1286872 - Split out toolbox styles from toolbars.css.

https://reviewboard.mozilla.org/r/64272/#review61304

Nice cleanup!
Attachment #8770996 - Flags: review?(bgrinstead) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/626f03d8438f
Split out toolbox styles from toolbars.css. r=bgrins
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/a8ab215f15d3
followup: move some leftover command-button styles to toolbox.css. r=me
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/18e2d06b428f
followup: move back --tool-options-image to toolbars.css to avoid disappearing icons. r=me
https://hg.mozilla.org/mozilla-central/rev/626f03d8438f
https://hg.mozilla.org/mozilla-central/rev/a8ab215f15d3
https://hg.mozilla.org/mozilla-central/rev/18e2d06b428f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Depends on: 1327999
Depends on: 1328000
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.