1286872 - Split out toolbox styles from toolbars.css

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1286872 - Split out toolbox styles from toolbars.css.

Review commit: https://reviewboard.mozilla.org/r/64272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64272/

Comment 2

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #14)
> Comment on attachment 8770988 [details] [diff] [review]
> Part 1: Move toolbox styles from toolbars.css to toolbox.css
> 
> Review of attachment 8770988 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks fine but can you move this into a separate bug that blocks Bug
> 1285745 instead of doing it here?
> 
> ::: devtools/client/themes/toolbox.css
> @@ +2,5 @@
> >  /* This Source Code Form is subject to the terms of the Mozilla Public
> >   * License, v. 2.0. If a copy of the MPL was not distributed with this
> >   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> >  
> > +.theme-light, .theme-dark {
> 
> Can you make this :root instead?  Just in case a new variable gets added
> that doesn't also get added to firebug at least there will be a default
> value.
Done.

> @@ +295,3 @@
> >  
> >  #command-button-paintflashing::before {
> > +  background-image: var(--command-paintflashing-image);
> 
> What changed on these lines?
I've fixed up the indentation to use 2 spaces. Should be more obvious now that I've pushed to MozReview.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8770996 [details]
Bug 1286872 - Split out toolbox styles from toolbars.css.

https://reviewboard.mozilla.org/r/64272/#review61304

Nice cleanup!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/626f03d8438f
Split out toolbox styles from toolbars.css. r=bgrins

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/a8ab215f15d3
followup: move some leftover command-button styles to toolbox.css. r=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/18e2d06b428f
followup: move back --tool-options-image to toolbars.css to avoid disappearing icons. r=me

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/626f03d8438f
https://hg.mozilla.org/mozilla-central/rev/a8ab215f15d3
https://hg.mozilla.org/mozilla-central/rev/18e2d06b428f