useless emacs cookies in many files

RESOLVED FIXED in Firefox 50

Status

defect
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
mozilla50
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Bug 855465 added emacs cookies to moz.build files like:

# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-

However, this is mildly incorrect, as Python mode doesn't use c-basic-offset.

This isn't actually limited to moz.build files; e.g. see testing/talos/talos/whitelist.py
for one example.

I'll attach a perl-generated patch to fix this.
Assignee

Comment 1

3 years ago
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

Review commit: https://reviewboard.mozilla.org/r/64276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64276/
Attachment #8770997 - Flags: review?(gps)
Comment on attachment 8770997 [details]
Bug 1286877 - do not set c-basic-offset for python-mode;

https://reviewboard.mozilla.org/r/64276/#review61308

I'll take your word for it, as I'm not an emacs user and don't know how to verify this. It's easy enough to bulk change again if we need to.
Attachment #8770997 - Flags: review?(gps) → review+
Assignee

Comment 3

3 years ago
Comment on attachment 8770997 [details]
Bug 1286877 - do not set c-basic-offset for python-mode;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64276/diff/1-2/
Assignee

Comment 5

3 years ago
Comment on attachment 8770997 [details]
Bug 1286877 - do not set c-basic-offset for python-mode;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64276/diff/2-3/
Assignee

Comment 6

3 years ago
Rebased and fixed one more new instance.

Comment 7

3 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ec6380fca82
do not set c-basic-offset for python-mode; r=gps

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ec6380fca82
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

Comment 9

2 years ago
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/87c73ef55f94
do not set c-basic-offset for python-mode; r=gps

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.