1286877 - useless emacs cookies in many files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Tom Tromey :tromey]

Bug 855465 added emacs cookies to moz.build files like:

# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-

However, this is mildly incorrect, as Python mode doesn't use c-basic-offset.

This isn't actually limited to moz.build files; e.g. see testing/talos/talos/whitelist.py
for one example.

I'll attach a perl-generated patch to fix this.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1286877 - do not set c-basic-offset for python-mode;

This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

Review commit: https://reviewboard.mozilla.org/r/64276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64276/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8770997 [details]
Bug 1286877 - do not set c-basic-offset for python-mode;

https://reviewboard.mozilla.org/r/64276/#review61308

I'll take your word for it, as I'm not an emacs user and don't know how to verify this. It's easy enough to bulk change again if we need to.

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8770997 [details]
Bug 1286877 - do not set c-basic-offset for python-mode;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64276/diff/1-2/

Comment 4

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5abe282c671

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8770997 [details]
Bug 1286877 - do not set c-basic-offset for python-mode;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64276/diff/2-3/

Comment 6

[Tom Tromey :tromey]

Rebased and fixed one more new instance.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec6380fca82
do not set c-basic-offset for python-mode; r=gps

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ec6380fca82

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/87c73ef55f94
do not set c-basic-offset for python-mode; r=gps