1286902 - Ordering accounts is not working

Status: RESOLVED FIXED

Description

[Abdelrhman Ahmed [:abdelrhman]]

Steps to reproduce:
1. Add two or more accounts in Instantbird
2. Try to reorder them (using drag and drop)

Error:
JavaScript error: chrome://instantbird/content/accounts.xul, line 1: ReferenceError: nsDragAndDrop is not defined

Expected result:
Accounts are reordered

Comment 1

[Patrick Cloke [:clokep]]

It seems that bug 1162050 completely removed the nsDragAndDrop file from toolkit. I thought we had handled this at some point already though...

Comment 2

[aleth [:aleth]]

The simplest solution would be to re-add nsDragAndDrop.js - this is what TB seems to have done:
https://dxr.mozilla.org/comm-central/source/mail/base/content/nsDragAndDrop.js

Not sure how much work rewriting the call sites would be.

Comment 3

[aleth [:aleth]]

Hmm, additionally, it seems the rename from bug 1186516 may not have been enough. We should check the issue from Bug 1171979 comment 14.

Comment 4

[aleth [:aleth]]

Created attachment 8793853 [details] [diff] [review]
Restore nsDragAndDrop.js

Let's just get this working again for now.

Comment 5

[Jorg K (GMT+2) (bustage-fix and urgent reviews only)]

Comment on attachment 8793853 [details] [diff] [review]
Restore nsDragAndDrop.js

Review of attachment 8793853 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if it works ;-)

::: im/content/jar.mn
@@ +100,5 @@
>  * 	content/instantbird/license.html                        (/mozilla/toolkit/content/license.html)
>  % override chrome://global/content/license.html chrome://instantbird/content/license.html
>  
> +toolkit.jar:
> +# toolkit dropped nsDragAndDrop.js in bug 1162050. ship a copy until we can remove it.

Nit. Uppercase "ship" ;-)

Comment 6

[Patrick Cloke [:clokep]]

Comment on attachment 8793853 [details] [diff] [review]
Restore nsDragAndDrop.js

Review of attachment 8793853 [details] [diff] [review]:
-----------------------------------------------------------------

A bit of a gross hack, but that's OK with me.

Comment 7

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/379a1f4356786bff4503513e31b7278b0a2bcca8
Bug 1286902 - Restore nsDragAndDrop.js. r=clokep