Ordering accounts is not working

RESOLVED FIXED in Instantbird 52

Status

Instantbird
Account manager
--
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: abdelrhman, Assigned: aleth)

Tracking

trunk
Instantbird 52
Dependency tree / graph

Details

(Whiteboard: [1.6-blocking])

Attachments

(1 attachment)

1.50 KB, patch
clokep
: review+
Jorg K (GMT+2) (bustage-fix and urgent reviews only)
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

2 years ago
Steps to reproduce:
1. Add two or more accounts in Instantbird
2. Try to reorder them (using drag and drop)

Error:
JavaScript error: chrome://instantbird/content/accounts.xul, line 1: ReferenceError: nsDragAndDrop is not defined

Expected result:
Accounts are reordered
It seems that bug 1162050 completely removed the nsDragAndDrop file from toolkit. I thought we had handled this at some point already though...
Severity: normal → major
Whiteboard: [1.6-blocking]
(Assignee)

Comment 2

2 years ago
The simplest solution would be to re-add nsDragAndDrop.js - this is what TB seems to have done:
https://dxr.mozilla.org/comm-central/source/mail/base/content/nsDragAndDrop.js

Not sure how much work rewriting the call sites would be.
(Assignee)

Updated

2 years ago
Blocks: 1162050
(Assignee)

Comment 3

2 years ago
Hmm, additionally, it seems the rename from bug 1186516 may not have been enough. We should check the issue from Bug 1171979 comment 14.
(Assignee)

Comment 4

2 years ago
Created attachment 8793853 [details] [diff] [review]
Restore nsDragAndDrop.js

Let's just get this working again for now.
Attachment #8793853 - Flags: review?(clokep)
(Assignee)

Updated

2 years ago
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8793853 [details] [diff] [review]
Restore nsDragAndDrop.js

Review of attachment 8793853 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if it works ;-)

::: im/content/jar.mn
@@ +100,5 @@
>  * 	content/instantbird/license.html                        (/mozilla/toolkit/content/license.html)
>  % override chrome://global/content/license.html chrome://instantbird/content/license.html
>  
> +toolkit.jar:
> +# toolkit dropped nsDragAndDrop.js in bug 1162050. ship a copy until we can remove it.

Nit. Uppercase "ship" ;-)
Attachment #8793853 - Flags: feedback+
Comment on attachment 8793853 [details] [diff] [review]
Restore nsDragAndDrop.js

Review of attachment 8793853 [details] [diff] [review]:
-----------------------------------------------------------------

A bit of a gross hack, but that's OK with me.
Attachment #8793853 - Flags: review?(clokep) → review+
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 52
You need to log in before you can comment on or make changes to this bug.