Closed
Bug 1286902
Opened 5 years ago
Closed 5 years ago
Ordering accounts is not working
Categories
(Instantbird :: Account manager, defect)
Instantbird
Account manager
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 52
People
(Reporter: abdelrahman, Assigned: aleth)
References
Details
(Whiteboard: [1.6-blocking])
Attachments
(1 file)
1.50 KB,
patch
|
clokep
:
review+
jorgk-bmo
:
feedback+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Add two or more accounts in Instantbird 2. Try to reorder them (using drag and drop) Error: JavaScript error: chrome://instantbird/content/accounts.xul, line 1: ReferenceError: nsDragAndDrop is not defined Expected result: Accounts are reordered
Comment 1•5 years ago
|
||
It seems that bug 1162050 completely removed the nsDragAndDrop file from toolkit. I thought we had handled this at some point already though...
Severity: normal → major
Whiteboard: [1.6-blocking]
Assignee | ||
Comment 2•5 years ago
|
||
The simplest solution would be to re-add nsDragAndDrop.js - this is what TB seems to have done: https://dxr.mozilla.org/comm-central/source/mail/base/content/nsDragAndDrop.js Not sure how much work rewriting the call sites would be.
Assignee | ||
Comment 3•5 years ago
|
||
Hmm, additionally, it seems the rename from bug 1186516 may not have been enough. We should check the issue from Bug 1171979 comment 14.
Assignee | ||
Comment 4•5 years ago
|
||
Let's just get this working again for now.
Attachment #8793853 -
Flags: review?(clokep)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 5•5 years ago
|
||
Comment on attachment 8793853 [details] [diff] [review] Restore nsDragAndDrop.js Review of attachment 8793853 [details] [diff] [review]: ----------------------------------------------------------------- Looks good if it works ;-) ::: im/content/jar.mn @@ +100,5 @@ > * content/instantbird/license.html (/mozilla/toolkit/content/license.html) > % override chrome://global/content/license.html chrome://instantbird/content/license.html > > +toolkit.jar: > +# toolkit dropped nsDragAndDrop.js in bug 1162050. ship a copy until we can remove it. Nit. Uppercase "ship" ;-)
Attachment #8793853 -
Flags: feedback+
Comment 6•5 years ago
|
||
Comment on attachment 8793853 [details] [diff] [review] Restore nsDragAndDrop.js Review of attachment 8793853 [details] [diff] [review]: ----------------------------------------------------------------- A bit of a gross hack, but that's OK with me.
Attachment #8793853 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 7•5 years ago
|
||
https://hg.mozilla.org/comm-central/rev/379a1f4356786bff4503513e31b7278b0a2bcca8 Bug 1286902 - Restore nsDragAndDrop.js. r=clokep
Assignee | ||
Updated•5 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 52
You need to log in
before you can comment on or make changes to this bug.
Description
•