1286937 - Make review links for mozreview, github, and splinter links more descriptive

Status: RESOLVED WONTFIX

(bugzilla.mozilla.org :: User Interface, defect)

Description

[David Lawrence [:dkl]]

+++ This bug was initially created as a clone of Bug #1286446 +++

i assume that "ext review" means "external review".
the word "external" should be spelt out explicitly, like "splinter review".

that said, i don't think "external" is appropriate for mozreview links - while mozreview is external to bugzilla, it isn't external to mozilla and shouldn't be labelled as such.

i recommend:
- changing "ext review" to "MozReview" for MR urls
- changing "ext review" to "external review" for other external review tools

Comment 1

[David Lawrence [:dkl]]

Attachment: 1286937_1.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8771107 [details] [diff] [review]
1286937_1.patch

Review of attachment 8771107 [details] [diff] [review]:
-----------------------------------------------------------------

Rather than check the mime type (and have it hard-coded in several places) I'd prefer
we keep can_review() and add a review_type, that returns 'github', 'mozreview', or 'splinter'
and use those to format the review links.

r-

Comment 3

[Kohei Yoshino [:kohei]]

MozReview is gone, and the GitHub PR support will be removed in Bug 1286448.