1286947 - Should not use a loop to get a single item from a set

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robin Steuber (she/her) [:bytesized]]

I noticed this weird line when searching through the code base [1]:

      for (let anchorElement of anchors) {
        this._showPanel(notificationsToShow, anchorElement);
        break;
      }

I find this unconditional loop break to be very odd. Since the code does not loop, I would like to change this code such that it does not use a for loop.

[1] http://searchfox.org/mozilla-central/rev/e269c68bc594b4a858624d73f0d9eb002f3c0844/toolkit/modules/PopupNotifications.jsm#843

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: remove loop.patch

Patch replaces unnecessary loop with simply calling |next()| on the Set iterator.

Comment 2

[:Gijs (he/him)]

Comment on attachment 8771104 [details] [diff] [review]
remove loop.patch

Review of attachment 8771104 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 3

[Robin Steuber (she/her) [:bytesized]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8499b485c80c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4680463ffdd7
Replace unconditional break in loop with code that does not use a loop. r=gijs

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4680463ffdd7