Closed Bug 1286955 Opened 4 years ago Closed 4 years ago

Worker URL implementation misuses ErrorResult on multiple threads

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bzbarsky, Assigned: baku)

References

Details

Attachments

(1 file)

See bug 1224664 comment 14.  The ConstructorRunnable in URL.cpp uses an ErrorResult created on workers to call URLMainThread::Constructor.
Flags: needinfo?(amarchesini)
Attached patch url.patchSplinter Review
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8771252 - Flags: review?(bzbarsky)
Comment on attachment 8771252 [details] [diff] [review]
url.patch

r=me.  Hey, kills of that non-spec SYNTAX_ERR thing too.  ;)
Attachment #8771252 - Flags: review?(bzbarsky) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf2bb72412a0
Don't use an ErrorResult on multiple threads in the Worker URL implementation.  r=bzbarsky
backed out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d12f1688d4710d9e31f32b1fcf360539655222c5 for hazard failures from one of this csets
Flags: needinfo?(amarchesini)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eabda35065c1
Don't use an ErrorResult on multiple threads in the Worker URL implementation.  r=bzbarsky
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/eabda35065c1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.