Closed
Bug 1286955
Opened 9 years ago
Closed 9 years ago
Worker URL implementation misuses ErrorResult on multiple threads
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: baku)
References
Details
Attachments
(1 file)
|
5.22 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
See bug 1224664 comment 14. The ConstructorRunnable in URL.cpp uses an ErrorResult created on workers to call URLMainThread::Constructor.
Flags: needinfo?(amarchesini)
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8771252 -
Flags: review?(bzbarsky)
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8771252 [details] [diff] [review]
url.patch
r=me. Hey, kills of that non-spec SYNTAX_ERR thing too. ;)
Attachment #8771252 -
Flags: review?(bzbarsky) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf2bb72412a0
Don't use an ErrorResult on multiple threads in the Worker URL implementation. r=bzbarsky
|
|
||
Comment 4•9 years ago
|
||
backed out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d12f1688d4710d9e31f32b1fcf360539655222c5 for hazard failures from one of this csets
Flags: needinfo?(amarchesini)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eabda35065c1
Don't use an ErrorResult on multiple threads in the Worker URL implementation. r=bzbarsky
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(amarchesini)
|
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•