1286969 - Change phonebook to only replace ldap attributes which have changed

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[Gene Wood [:gene]]

https://github.com/mozilla/phonebook/pull/26

This PR makes phonebook only replace LDAP attributes which have changed. This simplifies the LDIF transaction and audit logs.

I've not tested this change since I don't have a QA phonebook deployment, but the few lines should be easy to read and understand and should be easy to test (if there's a test system).

The driver for this PR is that currently infosec audits changes in LDAP to detect security problems. Those audit records are filled with LDAP attribute changes from phonebook where a user goes into their phonebook entry, changes one value, and phonebook submits an LDAP transaction which changes *all* of the users attributes (most of them being change to the same value that they already have).

Comment 1

[:Atoll]

We ended up deploying pull #28 in CHG0010767, verified in dev/stage to do the right thing in LDAP.

Comment 2

[Gene Wood [:gene]]

Slight correction, atoll ended up deploying #38 (not #28) in CHG0010767

https://github.com/mozilla/phonebook/pull/38#issuecomment-245789965

Comment 3

[:Atoll]

Ah, thanks, dyslexia strikes again