1286986 - Enable process-local registration of COM proxies at runtime

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1286986: Add glue to enable process-local registration of COM proxies at runtime;

Review commit: https://reviewboard.mozilla.org/r/65276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65276/

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

This patch allows us to safely steer around the "never register IA2Marshal.dll in the registry" pact.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8772486 [details]
Bug 1286986: Add glue to enable process-local registration of COM proxies at runtime;

https://reviewboard.mozilla.org/r/65276/#review62962

::: ipc/mscom/Registration.cpp:68
(Diff revision 1)
> +  } else if (aFlags == RegistrationFlags::eUseSystemDirectory) {
> +    UINT result = GetSystemDirectoryW(aBuffer, static_cast<UINT>(aBufferLen));
> +    if (!result || result > aBufferLen) {
> +      return false;
> +    }
> +  }

should we catch the fall through with a not_reached assert or return of false? All we would get here is a call to PathAppend.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Jim Mathies [:jimm] from comment #3)
> Comment on attachment 8772486 [details]
> Bug 1286986: Add glue to enable process-local registration of COM proxies at
> runtime;
> 
> https://reviewboard.mozilla.org/r/65276/#review62962
> 
> ::: ipc/mscom/Registration.cpp:68
> (Diff revision 1)
> > +  } else if (aFlags == RegistrationFlags::eUseSystemDirectory) {
> > +    UINT result = GetSystemDirectoryW(aBuffer, static_cast<UINT>(aBufferLen));
> > +    if (!result || result > aBufferLen) {
> > +      return false;
> > +    }
> > +  }
> 
> should we catch the fall through with a not_reached assert or return of
> false? All we would get here is a call to PathAppend.

Good idea.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8772486 [details]
Bug 1286986: Add glue to enable process-local registration of COM proxies at runtime;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65276/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/321ad9fd9a84
Add glue to enable process-local registration of COM proxies at runtime; r=jimm

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/321ad9fd9a84