Closed Bug 1286986 Opened 3 years ago Closed 3 years ago

Enable process-local registration of COM proxies at runtime

Categories

(Core :: Disability Access APIs, defect)

Unspecified
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This patch allows us to safely steer around the "never register IA2Marshal.dll in the registry" pact.
Blocks: 1288199
Comment on attachment 8772486 [details]
Bug 1286986: Add glue to enable process-local registration of COM proxies at runtime;

https://reviewboard.mozilla.org/r/65276/#review62962

::: ipc/mscom/Registration.cpp:68
(Diff revision 1)
> +  } else if (aFlags == RegistrationFlags::eUseSystemDirectory) {
> +    UINT result = GetSystemDirectoryW(aBuffer, static_cast<UINT>(aBufferLen));
> +    if (!result || result > aBufferLen) {
> +      return false;
> +    }
> +  }

should we catch the fall through with a not_reached assert or return of false? All we would get here is a call to PathAppend.
Attachment #8772486 - Flags: review?(jmathies) → review+
(In reply to Jim Mathies [:jimm] from comment #3)
> Comment on attachment 8772486 [details]
> Bug 1286986: Add glue to enable process-local registration of COM proxies at
> runtime;
> 
> https://reviewboard.mozilla.org/r/65276/#review62962
> 
> ::: ipc/mscom/Registration.cpp:68
> (Diff revision 1)
> > +  } else if (aFlags == RegistrationFlags::eUseSystemDirectory) {
> > +    UINT result = GetSystemDirectoryW(aBuffer, static_cast<UINT>(aBufferLen));
> > +    if (!result || result > aBufferLen) {
> > +      return false;
> > +    }
> > +  }
> 
> should we catch the fall through with a not_reached assert or return of
> false? All we would get here is a call to PathAppend.

Good idea.
Comment on attachment 8772486 [details]
Bug 1286986: Add glue to enable process-local registration of COM proxies at runtime;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65276/diff/1-2/
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/321ad9fd9a84
Add glue to enable process-local registration of COM proxies at runtime; r=jimm
https://hg.mozilla.org/mozilla-central/rev/321ad9fd9a84
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.