Closed
Bug 1286988
Opened 8 years ago
Closed 8 years ago
Cisco Spark BMO bot configured to lookup room name; consider using room identifier
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: paulej, Assigned: dkl)
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
The Cisco Spark BMO bot looks up the room name to determine the room ID. Since anyone can change the room name at any time, this is fragile. Consider using the room ID as the configuration parameter. Saves one API call, too. :)
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Removes the need to first do the look up for the room id and just uses what the admin provides in the configuration. Simplifies the code. There is a room called 'Bugzilla (Testing)' which can be used for testing purposes. room id: Y2lzY29zcGFyazovL3VzL1JPT00vYTlmOTQ0NDAtZGE1Yy0xMWU1LWFlOGEtNWQ0YmI0MTRiMTM4 dkl
Attachment #8773480 -
Flags: review?(dylan)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8773480 [details] [diff] [review] 1286988_1.patch r=dylan
Attachment #8773480 -
Flags: review?(dylan) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
To https://github.com/mozilla-bteam/bmo.git 7bc7cd3..6e47481 master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Extensions: Push → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•